Skip to content

fix(ivy): fix PR collision with static: true and new test - #30666

Closed
alxhub wants to merge 1 commit into
angular:masterfrom
alxhub:fix/styling-collision
Closed

alxhub wants to merge 1 commit into
angular:masterfrom
alxhub:fix/styling-collision

Conversation

@alxhub

@alxhub alxhub commented May 24, 2019

Copy link
Copy Markdown
Member

This fixes a collision between #30639 and #30543 where the latter added
usages of @ViewChild without the static flag present, but the former
made the flag required.

This fixes a collision between angular#30639 and angular#30543 where the latter added
usages of @ViewChild without the static flag present, but the former
made the flag required.
@alxhub
alxhub requested a review from a team May 24, 2019 21:44
@alxhub alxhub added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed cla: yes labels May 24, 2019

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matsko matsko closed this in 661c6e6 May 24, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants