Skip to content

docs: merge duplicated platform-webworker content in Deprecation Guide - #30651

Closed
Splaktar wants to merge 1 commit into
angular:masterfrom
DevIntent:docsDeprecation-extraWebWorkerContent
Closed

docs: merge duplicated platform-webworker content in Deprecation Guide#30651
Splaktar wants to merge 1 commit into
angular:masterfrom
DevIntent:docsDeprecation-extraWebWorkerContent

Conversation

@Splaktar

@Splaktar Splaktar commented May 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

We now have duplicated anchors and platform-webworker deprecation sections.

The one from PR #30598:
is right above https://next.angular.io/guide/deprecations#platform-webworker-angular-applications

The one from PR #30642:
https://next.angular.io/guide/deprecations#platform-webworker-angular-applications

The platform-webworker id is defined twice:

Issue Number: N/A

What is the new behavior?

  • merge duplicated platform-webworker content
  • fix issue of duplicate anchors/ids

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

cc @alxhub @kapunahelewong

@Splaktar
Splaktar requested a review from IgorMinar as a code owner May 24, 2019 07:26
@Splaktar
Splaktar force-pushed the docsDeprecation-extraWebWorkerContent branch from 8c8e67d to bc18c41 Compare May 24, 2019 07:37
@ngbot ngbot Bot added this to the needsTriage milestone May 24, 2019
@ngbot ngbot Bot modified the milestones: needsTriage, Backlog May 24, 2019
@mary-poppins

mary-poppins commented May 28, 2019

Copy link
Copy Markdown

You can preview 8c8e67d at https://pr30651-8c8e67d.ngbuilds.io/.
You can preview bc18c41 at https://pr30651-bc18c41.ngbuilds.io/.

jenniferfell
jenniferfell approved these changes May 29, 2019
View reviewed changes

@jenniferfell jenniferfell left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, but I didn't notice anything that was a merge stopper. Added aio-preview so this can be reviewed in markdown and from the user's POV.

Comment thread aio/content/guide/deprecations.md Resolved
Comment thread aio/content/guide/deprecations.md Resolved
Comment thread aio/content/guide/deprecations.md Resolved
@Splaktar
Splaktar force-pushed the docsDeprecation-extraWebWorkerContent branch from bc18c41 to 9e8ec4c Compare May 29, 2019 18:09
@mary-poppins

mary-poppins commented May 29, 2019

Copy link
Copy Markdown

You can preview 9e8ec4c at https://pr30651-9e8ec4c.ngbuilds.io/.

@Splaktar
Splaktar force-pushed the docsDeprecation-extraWebWorkerContent branch from 9e8ec4c to e1eccbe Compare May 29, 2019 18:40
@mary-poppins

mary-poppins commented May 29, 2019

Copy link
Copy Markdown

You can preview e1eccbe at https://pr30651-e1eccbe.ngbuilds.io/.

@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label May 30, 2019
@brandonroberts brandonroberts self-assigned this May 30, 2019
@ngbot

ngbot Bot commented May 30, 2019

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci-codefresh-bazel" is failing
    pending missing required labels: PR target: *
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 30, 2019
@brandonroberts

brandonroberts commented May 30, 2019

Copy link
Copy Markdown
Contributor

Caretaker note: Codfresh build failure is unrelated

@matsko matsko added the target: patch This PR is targeted for the next patch release label May 30, 2019
matsko pushed a commit that referenced this pull request May 30, 2019
@Splaktar @matsko
docs: merge duplicated platform-webworker content in Deprecation Guide (
cfc608a 
#30651)

fix issue of duplicate anchors/ids

PR Close #30651
@matsko matsko closed this in 6a5cc8f May 30, 2019
@Splaktar
Splaktar deleted the docsDeprecation-extraWebWorkerContent branch May 30, 2019 18:42
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IgorMinar IgorMinar Awaiting requested review from IgorMinar
1 more reviewer
@jenniferfell jenniferfell jenniferfell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@brandonroberts brandonroberts

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq3: high merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

7 participants

@Splaktar @mary-poppins @brandonroberts @jenniferfell @matsko @kapunahelewong @googlebot