Skip to content

docs(core): add migration guide for static queries - #30644

Closed
kara wants to merge 9 commits into
angular:masterfrom
kara:query-guide
Closed

docs(core): add migration guide for static queries#30644
kara wants to merge 9 commits into
angular:masterfrom
kara:query-guide

Conversation

@kara

@kara kara commented May 23, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@mary-poppins

mary-poppins commented May 23, 2019

Copy link
Copy Markdown

You can preview 4698539 at https://pr30644-4698539.ngbuilds.io/.

@kara kara added area: core Issues related to the framework runtime comp: docs labels May 23, 2019
@ngbot ngbot Bot added this to the needsTriage milestone May 23, 2019
@kara kara added hotlist: release-blocker action: review The PR is still awaiting reviews from at least one requested reviewer labels May 23, 2019
@kara
kara marked this pull request as ready for review May 23, 2019 21:21
@kara
kara requested a review from IgorMinar as a code owner May 23, 2019 21:21
@mary-poppins

mary-poppins commented May 23, 2019

Copy link
Copy Markdown

You can preview f902eab at https://pr30644-f902eab.ngbuilds.io/.

@angular angular deleted a comment from mary-poppins May 23, 2019
@angular angular deleted a comment from mary-poppins May 23, 2019
JoostK
JoostK reviewed May 23, 2019
View reviewed changes
Comment thread aio/content/guide/static-query-migration.md Resolved
@kara kara removed the aio: preview label May 23, 2019
IgorMinar
IgorMinar reviewed May 23, 2019
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review still wip... posting what I have so far

Comment thread aio/content/guide/static-query-migration.md Resolved
Comment thread aio/content/guide/static-query-migration.md Resolved
@mary-poppins

mary-poppins commented May 23, 2019

Copy link
Copy Markdown

You can preview e0b193d at https://pr30644-e0b193d.ngbuilds.io/.

@angular angular deleted a comment from mary-poppins May 23, 2019
@angular angular deleted a comment from mary-poppins May 23, 2019
@angular angular deleted a comment from mary-poppins May 23, 2019
@angular angular deleted a comment from mary-poppins May 23, 2019
@angular angular deleted a comment from mary-poppins May 23, 2019
@angular angular deleted a comment from mary-poppins May 23, 2019
IgorMinar
IgorMinar approved these changes May 23, 2019
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding Q: Will this break existing libraries that haven’t updated to version 8 yet? (or Can I keep on using Angular libraries that haven’t yet updated to version 8 yet?)

otherwise looks great!

Comment thread aio/content/guide/static-query-migration.md Resolved
Comment thread aio/content/guide/static-query-migration.md Resolved
Comment thread aio/content/guide/static-query-migration.md Resolved
@angular angular deleted a comment from mary-poppins May 23, 2019
@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 23, 2019
@mary-poppins

mary-poppins commented May 23, 2019

Copy link
Copy Markdown

You can preview c63fc9c at https://pr30644-c63fc9c.ngbuilds.io/.

@kara kara added the target: patch This PR is targeted for the next patch release label May 23, 2019
@jasonaden jasonaden added the action: merge The PR is ready for merge by the caretaker label May 23, 2019
@mary-poppins

mary-poppins commented May 23, 2019

Copy link
Copy Markdown

You can preview 475d722 at https://pr30644-475d722.ngbuilds.io/.

@jasonaden jasonaden closed this in 9b035e4 May 23, 2019
jasonaden pushed a commit that referenced this pull request May 23, 2019
@kara @jasonaden
docs(core): update deprecations guide (#30644)
2508872 
PR Close #30644
jasonaden pushed a commit that referenced this pull request May 23, 2019
@kara @jasonaden
docs(core): add migration guide for static queries (#30644)
c567135 
PR Close #30644
jasonaden pushed a commit that referenced this pull request May 23, 2019
@kara @jasonaden
docs(core): update deprecations guide (#30644)
063cc30 
PR Close #30644
@kara kara mentioned this pull request May 24, 2019
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK left review comments
@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource left review comments
+1 more reviewer
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

7 participants

@kara @mary-poppins @JoostK @IgorMinar @pkozlowski-opensource @jasonaden @googlebot