Skip to content

v8.0 remaining deprecations - #30642

Closed
alxhub wants to merge 2 commits into
angular:masterfrom
alxhub:v8/deprecations
Closed

alxhub wants to merge 2 commits into
angular:masterfrom
alxhub:v8/deprecations

Conversation

@alxhub

@alxhub alxhub commented May 23, 2019

Copy link
Copy Markdown
Member

Two deprecations for 8.0.

@alxhub alxhub added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release hotlist: release-blocker labels May 23, 2019
@alxhub
alxhub requested review from a team May 23, 2019 19:57
@alxhub

alxhub commented May 23, 2019

Copy link
Copy Markdown
Member Author

Presubmit

@kara kara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IgorMinar IgorMinar changed the title V8/deprecations v8.0 remaining deprecations May 23, 2019

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please list the deprecated symbols in the deprecation's guide index table https://github.com/angular/angular/blob/master/aio/content/guide/deprecations.md#index

thanks!

@alxhub
alxhub force-pushed the v8/deprecations branch from 8699ddb to 7fecd09 Compare May 23, 2019 20:27
@alxhub

alxhub commented May 23, 2019

Copy link
Copy Markdown
Member Author

@IgorMinar done!

@Splaktar Splaktar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that the platform-webworker* API will be removed in version 10? do we need to specify that in the multiple comments? or should that just be reflected in the deprecation guide?

Comment thread aio/content/guide/deprecations.md Resolved
Comment thread aio/content/guide/deprecations.md Resolved
Comment thread aio/content/guide/deprecations.md Resolved
Comment thread aio/content/guide/deprecations.md Resolved
alxhub added 2 commits May 23, 2019 14:06
DEPRECATION:

Angular previously has supported an integration with the Web Tracing
Framework (WTF) for performance testing of Angular applications. This
integration has not been maintained and likely does not work for the
majority of Angular applications today. As a result, we are deprecating
the integration in Angular version 8.

This deprecation covers the following public APIs:
* `WtfScopeFn`
* `wtfCreateScope`
* `wtfStartTimeRange`
* `wtfEndTimeRange`
* `wtfLeave`

FW-1338 #resolve
DEPRECATION:

platform-webworker has been around since the initial release of Angular
version 2. It began as an experiment to leverage Angular's rendering
architecture and try something different: to run an entire web application
in a web worker.

We've learned a lot from this experiment, and have come to the conclusion
that pushing entire applications to run in a web worker is not a recipe for
success for most applications. This is due to a number of unresolved issues,
including:

* Poor or non-existent support for web worker APIs in web crawlers/indexers.
* Poor support in build and bundling tooling.

As a result, as of Angular version 8, we are deprecating the
`platform-webworker` APIs in Angular. This consists of both NPM packages,
`@angular/platform-webworker` and `@angular/platform-webworker-dynamic`.

Going forward, we will focus our efforts related to web workers around their
primary use case of offloading CPU-intensive but not critical work.

FW-1339 #resolve
@mary-poppins

Copy link
Copy Markdown

You can preview 8699ddb at https://pr30642-8699ddb.ngbuilds.io/.
You can preview 7fecd09 at https://pr30642-7fecd09.ngbuilds.io/.
You can preview 9fe8df8 at https://pr30642-9fe8df8.ngbuilds.io/.

@jasonaden jasonaden closed this in f310a59 May 23, 2019
jasonaden pushed a commit that referenced this pull request May 23, 2019
DEPRECATION:

platform-webworker has been around since the initial release of Angular
version 2. It began as an experiment to leverage Angular's rendering
architecture and try something different: to run an entire web application
in a web worker.

We've learned a lot from this experiment, and have come to the conclusion
that pushing entire applications to run in a web worker is not a recipe for
success for most applications. This is due to a number of unresolved issues,
including:

* Poor or non-existent support for web worker APIs in web crawlers/indexers.
* Poor support in build and bundling tooling.

As a result, as of Angular version 8, we are deprecating the
`platform-webworker` APIs in Angular. This consists of both NPM packages,
`@angular/platform-webworker` and `@angular/platform-webworker-dynamic`.

Going forward, we will focus our efforts related to web workers around their
primary use case of offloading CPU-intensive but not critical work.

FW-1339 #resolve

PR Close #30642
jasonaden pushed a commit that referenced this pull request May 23, 2019
#30642)

DEPRECATION:

Angular previously has supported an integration with the Web Tracing
Framework (WTF) for performance testing of Angular applications. This
integration has not been maintained and likely does not work for the
majority of Angular applications today. As a result, we are deprecating
the integration in Angular version 8.

This deprecation covers the following public APIs:
* `WtfScopeFn`
* `wtfCreateScope`
* `wtfStartTimeRange`
* `wtfEndTimeRange`
* `wtfLeave`

FW-1338 #resolve

PR Close #30642
jasonaden pushed a commit that referenced this pull request May 23, 2019
DEPRECATION:

platform-webworker has been around since the initial release of Angular
version 2. It began as an experiment to leverage Angular's rendering
architecture and try something different: to run an entire web application
in a web worker.

We've learned a lot from this experiment, and have come to the conclusion
that pushing entire applications to run in a web worker is not a recipe for
success for most applications. This is due to a number of unresolved issues,
including:

* Poor or non-existent support for web worker APIs in web crawlers/indexers.
* Poor support in build and bundling tooling.

As a result, as of Angular version 8, we are deprecating the
`platform-webworker` APIs in Angular. This consists of both NPM packages,
`@angular/platform-webworker` and `@angular/platform-webworker-dynamic`.

Going forward, we will focus our efforts related to web workers around their
primary use case of offloading CPU-intensive but not critical work.

FW-1339 #resolve

PR Close #30642
@Splaktar

Copy link
Copy Markdown
Contributor

I got pulled away for a bit after the AIO preview was posted, so I didn't get a chance to look at it. We now have duplicated anchors and platform-webworker deprecation sections.

The one from PR #30598:
is right above https://next.angular.io/guide/deprecations#platform-webworker-angular-applications

The one from this PR:
https://next.angular.io/guide/deprecations#platform-webworker-angular-applications

The platform-webworker id is defined twice:

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants