Repository navigation
refactor(core): static-query migration should always use template strategy - #30628
Closed
devversion wants to merge 2 commits into
Closed
devversion wants to merge 2 commits into
devversion wants to merge 2 commits into
Conversation
devversion
commented
May 23, 2019
devversion
commented
Member
- See individual commits.
…ategy We are removing the prompt for the `static-query` migration and make the template strategy the migration strategy for the migration. The usage strategy is good for best-practices, but for now we want to ensure that the migration is a seamless as possible and that is only achievable my re-using the same logic that View Engine uses for determining the timing of a query.
devversion
added
action: review
devversion
marked this pull request as ready for review
May 23, 2019 00:43
Currently if a project has source-files with syntax failures and the migration has been started on a broken project, we silently migrate *as much as possible*, but never notify the developer that the project was in a broken state and that he can re-run the migration after the failures are fixed. Additionally the template strategy does not need to exit gracefully if it detects Angular semantic diagnostics on generated files (template type checking). These diagnostics are not relevant for the query timing analysis.
devversion
force-pushed
the
version8-static-query-migration-changes
branch
from
May 23, 2019 00:56
590405f to
40c350f
Compare
Splaktar
approved these changes
May 23, 2019
Contributor
|
@alxhub did you want to review this for working with new TS signature? |
Contributor
kara
added
action: merge
Contributor
|
merge-assistance: code fresh |
jasonaden
pushed a commit
that referenced
this pull request
May 23, 2019
…ategy (#30628) We are removing the prompt for the `static-query` migration and make the template strategy the migration strategy for the migration. The usage strategy is good for best-practices, but for now we want to ensure that the migration is a seamless as possible and that is only achievable my re-using the same logic that View Engine uses for determining the timing of a query. PR Close #30628
jasonaden
pushed a commit
that referenced
this pull request
May 23, 2019
…res (#30628) Currently if a project has source-files with syntax failures and the migration has been started on a broken project, we silently migrate *as much as possible*, but never notify the developer that the project was in a broken state and that he can re-run the migration after the failures are fixed. Additionally the template strategy does not need to exit gracefully if it detects Angular semantic diagnostics on generated files (template type checking). These diagnostics are not relevant for the query timing analysis. PR Close #30628
jasonaden
pushed a commit
that referenced
this pull request
May 23, 2019
…res (#30628) Currently if a project has source-files with syntax failures and the migration has been started on a broken project, we silently migrate *as much as possible*, but never notify the developer that the project was in a broken state and that he can re-run the migration after the failures are fixed. Additionally the template strategy does not need to exit gracefully if it detects Angular semantic diagnostics on generated files (template type checking). These diagnostics are not relevant for the query timing analysis. PR Close #30628
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.