Skip to content

test(core): update core tests (unrelated to queries) to use static flag - #30626

Closed
kara wants to merge 4 commits into
angular:masterfrom
kara:update-flag
Closed

test(core): update core tests (unrelated to queries) to use static flag#30626
kara wants to merge 4 commits into
angular:masterfrom
kara:update-flag

Conversation

@kara

@kara kara commented May 22, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@kara
kara force-pushed the update-flag branch 5 times, most recently from ec0309d to b66e2b7 Compare May 23, 2019 00:16
@kara kara added the comp: ivy label May 23, 2019
@ngbot ngbot Bot added this to the needsTriage milestone May 23, 2019
@kara kara added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer labels May 23, 2019
@kara
kara marked this pull request as ready for review May 23, 2019 00:23
@kara
kara requested a review from a team May 23, 2019 00:23
AndrewKushnir
AndrewKushnir approved these changes May 23, 2019
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 23, 2019
@kara

kara commented May 23, 2019

Copy link
Copy Markdown
Contributor Author

merge-assistance: code fresh

@kara
kara requested a review from IgorMinar as a code owner May 23, 2019 03:45
@kara
kara requested a review from a team May 23, 2019 03:45
@kara kara changed the title test(ivy): update core tests (unrelated to queries) to use static flag test(core): update core tests (unrelated to queries) to use static flag May 23, 2019
@kara kara added state: WIP and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels May 23, 2019
@kara kara added area: core Issues related to the framework runtime and removed state: WIP comp: ivy labels May 23, 2019
@IgorMinar IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 23, 2019
@IgorMinar

IgorMinar commented May 23, 2019

Copy link
Copy Markdown
Contributor

merge-assistance: windows ci is pending but can't be affected by this change

@jasonaden jasonaden closed this in 4299ecf May 23, 2019
jasonaden pushed a commit that referenced this pull request May 23, 2019
@kara @jasonaden
test(common): update common tests to use static flag (#30626)
dcdecfa 
PR Close #30626
jasonaden pushed a commit that referenced this pull request May 23, 2019
@kara @jasonaden
test(compiler): update examples and compiler tests (#30626)
214ae0e 
PR Close #30626
jasonaden pushed a commit that referenced this pull request May 23, 2019
@kara @jasonaden
test(core): update query-specific tests in core (#30626)
faac51f 
PR Close #30626
alxhub pushed a commit to alxhub/angular that referenced this pull request May 23, 2019
@kara @alxhub
test(core): update core tests (unrelated to queries) to use static fl…
e1cbb91 
…ag (angular#30626)

PR Close angular#30626
alxhub pushed a commit to alxhub/angular that referenced this pull request May 23, 2019
@kara @alxhub
test(common): update common tests to use static flag (angular#30626)
cf6943e 
PR Close angular#30626
alxhub pushed a commit to alxhub/angular that referenced this pull request May 23, 2019
@kara @alxhub
test(compiler): update examples and compiler tests (angular#30626)
8e62d15 
PR Close angular#30626
alxhub pushed a commit to alxhub/angular that referenced this pull request May 23, 2019
@kara @alxhub
test(core): update query-specific tests in core (angular#30626)
a25ddd1 
PR Close angular#30626
jasonaden pushed a commit that referenced this pull request May 23, 2019
@kara @jasonaden
test(core): update core tests (unrelated to queries) to use static fl…
f0c5400 
…ag (#30626) (#30641)

PR Close #30626

PR Close #30641
jasonaden pushed a commit that referenced this pull request May 23, 2019
@kara @jasonaden
test(common): update common tests to use static flag (#30626) (#30641)
7323072 
PR Close #30626

PR Close #30641
jasonaden pushed a commit that referenced this pull request May 23, 2019
@kara @jasonaden
test(compiler): update examples and compiler tests (#30626) (#30641)
04196ec 
PR Close #30626

PR Close #30641
jasonaden pushed a commit that referenced this pull request May 23, 2019
@kara @jasonaden
test(core): update query-specific tests in core (#30626) (#30641)
e2c9ddb 
PR Close #30626

PR Close #30641
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes
+1 more reviewer
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@kara @IgorMinar @AndrewKushnir @googlebot