docs: add v8 deprecations by kapunahelewong · Pull Request #30598 · angular/angular

kapunahelewong · 2019-05-21T21:37:30Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Adds v8 deprecated features to deprecation guide.

Does this PR introduce a breaking change?

Yes
No

Other information

mary-poppins · 2019-05-21T21:44:32Z

You can preview d155006 at https://pr30598-d155006.ngbuilds.io/.

kara

A good start! Sorry the doc was so vague (definitely implementation-focused rather than user-focused). Minor edits requested below

mary-poppins · 2019-05-22T18:55:44Z

You can preview 5e31b86 at https://pr30598-5e31b86.ngbuilds.io/.

mary-poppins · 2019-05-22T21:51:43Z

You can preview bfd4bbd at https://pr30598-bfd4bbd.ngbuilds.io/.

mary-poppins · 2019-05-22T22:16:59Z

You can preview be2c7ed at https://pr30598-be2c7ed.ngbuilds.io/.

Splaktar · 2019-05-22T22:06:14Z

Thanks for your input on this @trotyl 😄

Totally agree! @trotyl is great! 🙌🏼

Thank you both~

Also, technically /deep/ and >>> can be removed, which are already forbidden in preprocessor, the only thing matters is ::ng-deep.

mary-poppins · 2019-05-22T22:26:17Z

You can preview 5c067ab at https://pr30598-5c067ab.ngbuilds.io/.

mary-poppins · 2019-05-22T23:08:17Z

You can preview f039fd4 at https://pr30598-f039fd4.ngbuilds.io/.

Splaktar

LGTM

mary-poppins · 2019-05-22T23:31:37Z

You can preview 1a91f26 at https://pr30598-1a91f26.ngbuilds.io/.

kara

LGTM, but we should ask @IgorMinar if there's more context to add on wtf*

PR Close #30598

angular-automatic-lock-bot · 2019-09-15T05:51:29Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

kapunahelewong added type: bug/fix comp: docs effort1: hours risk: low labels May 21, 2019

kapunahelewong requested a review from IgorMinar as a code owner May 21, 2019 21:37

ngbot Bot added this to the Backlog milestone May 21, 2019

googlebot added the cla: yes label May 21, 2019

kapunahelewong requested a review from kara May 21, 2019 21:37

jasonaden added the hotlist: release-blocker label May 21, 2019

kara suggested changes May 22, 2019

View reviewed changes

kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 22, 2019

kara assigned kapunahelewong May 22, 2019

trotyl reviewed May 22, 2019

View reviewed changes

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

brandonroberts modified the milestones: Backlog, version 8 May 22, 2019

kara reviewed May 22, 2019

View reviewed changes

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

kara reviewed May 22, 2019

View reviewed changes

Comment thread aio/content/guide/deprecations.md Resolved

kapunahelewong mentioned this pull request May 22, 2019

Remove deprecated features from docs examples #30620

Closed

IgorMinar reviewed May 22, 2019

View reviewed changes

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

Comment thread aio/content/guide/deprecations.md Resolved

Splaktar suggested changes May 22, 2019

View reviewed changes

Splaktar reviewed May 22, 2019

View reviewed changes

Comment thread aio/content/guide/deprecations.md Resolved

Splaktar mentioned this pull request May 22, 2019

Platform is not described in documentation glossary #27096

Closed

docs: add v8 deprecations

1a91f26

Splaktar approved these changes May 22, 2019

View reviewed changes

kara approved these changes May 22, 2019

View reviewed changes

Splaktar mentioned this pull request May 23, 2019

refactor(core): static-query migration should always use template strategy #30628

Closed

brandonroberts added the target: patch This PR is targeted for the next patch release label May 23, 2019

kara added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 23, 2019

kara unassigned kapunahelewong May 23, 2019

kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 23, 2019

jasonaden closed this in b5c8939 May 23, 2019

jasonaden pushed a commit that referenced this pull request May 23, 2019

docs: add v8 deprecations (#30598)

3f2f937

PR Close #30598

This was referenced May 23, 2019

v8.0 remaining deprecations #30642

Closed

docs: merge duplicated platform-webworker content in Deprecation Guide #30651

Closed

kapunahelewong deleted the v8-deprecations branch June 20, 2019 18:19

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019

Conversation

kapunahelewong commented May 21, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

mary-poppins commented May 21, 2019

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented May 22, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented May 22, 2019

Uh oh!

mary-poppins commented May 22, 2019

Uh oh!

Splaktar May 22, 2019

Choose a reason for hiding this comment

Uh oh!

kapunahelewong May 22, 2019

Choose a reason for hiding this comment

Uh oh!

trotyl May 23, 2019

Choose a reason for hiding this comment

Uh oh!

trotyl May 23, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented May 22, 2019

Uh oh!

Uh oh!

mary-poppins commented May 22, 2019

Uh oh!

Splaktar left a comment

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented May 22, 2019

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 15, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone