Skip to content

docs(elements): move clarification about custom elements - #30594

Closed
BBKolton wants to merge 1 commit into
angular:masterfrom
BBKolton:patch-1
Closed

docs(elements): move clarification about custom elements#30594
BBKolton wants to merge 1 commit into
angular:masterfrom
BBKolton:patch-1

Conversation

@BBKolton

@BBKolton BBKolton commented May 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Moved clarification that "custom elements" are a subtype of Web Components to the first use of the term "custom elements"

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

No code changes

Does this PR introduce a breaking change?

  • Yes
  • No

@BBKolton
BBKolton requested a review from a team May 21, 2019 18:37
gkalpak
gkalpak approved these changes May 21, 2019
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Can you please change the commit message to something like:

docs(elements): move clarification about custom elements

...

@gkalpak gkalpak added comp: docs area: elements Issues related to Angular Elements action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels May 21, 2019
@ngbot ngbot Bot added this to the needsTriage milestone May 21, 2019
@ngbot ngbot Bot modified the milestones: needsTriage, Backlog May 21, 2019
@BBKolton BBKolton changed the title docs: Clarified that custom elements are a part of the Web Components standard docs(elements): move clarification about custom elements May 22, 2019
@googlebot

googlebot commented May 22, 2019

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@BBKolton

BBKolton commented May 22, 2019

Copy link
Copy Markdown
Contributor Author

Updated the commit message, forgive me if this isn't the format you're looking for. First contribution to open source (even if small) :)

@BBKolton

BBKolton commented May 22, 2019

Copy link
Copy Markdown
Contributor Author

Proc for cla/google bot

@BBKolton

BBKolton commented May 22, 2019

Copy link
Copy Markdown
Contributor Author

proc cla/google bot 2: electric boogaloo

@googlebot

googlebot commented May 22, 2019

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@BBKolton @brandonroberts
docs(elements): move clarification about custom elements
ad15f4e 
Moved clarification that "custom elements" are a subtype of Web Components to the first use of the term "custom elements"
@brandonroberts brandonroberts added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 28, 2019
@ngbot ngbot Bot added the action: merge The PR is ready for merge by the caretaker label May 28, 2019
matsko pushed a commit that referenced this pull request May 30, 2019
@BBKolton @matsko
docs(elements): move clarification about custom elements (#30594)
6d9f5fc 
Moved clarification that "custom elements" are a subtype of Web Components to the first use of the term "custom elements"

PR Close #30594
@matsko matsko closed this in 2c406fb May 30, 2019
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: elements Issues related to Angular Elements cla: yes effort1: hours freq1: low merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@BBKolton @googlebot @gkalpak @brandonroberts @kapunahelewong