Repository navigation
docs: remove call to run ngcc when running examples with ivy - #30592
Closed
brandonroberts wants to merge 1 commit into
Closed
brandonroberts wants to merge 1 commit into
brandonroberts wants to merge 1 commit into
Conversation
|
You can preview 38cc591 at https://pr30592-38cc591.ngbuilds.io/. |
Compilation with ngcc is now included in the CLI, so its no longer necessary to run in manually. Also modifies CI job to only run ngcc once before running test suites
brandonroberts
force-pushed
the
docs-examples-ivy-ngcc
branch
from
May 21, 2019 15:18
38cc591 to
060834b
Compare
Member
|
Unfortunately, I don't think this is a good change, because we are running multiple concurrent cli builds, all operating on the same (We should do this for aio itself though 😉 😉 😉) |
Contributor
Author
|
Gotcha. I just saw the other PR |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation with ngcc is now included in the CLI, so its no longer necessary
to run in manually
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information