Repository navigation
Conversation
kara
force-pushed
the
deprecatedOverrideProvider
branch
2 times, most recently
from
May 20, 2019 23:34
6f18717 to
8d7ffe0
Compare
|
You can preview 6f18717 at https://pr30576-6f18717.ngbuilds.io/. |
Contributor
Author
kara
added
action: presubmit
|
You can preview 8d7ffe0 at https://pr30576-8d7ffe0.ngbuilds.io/. |
kara
force-pushed
the
deprecatedOverrideProvider
branch
from
May 21, 2019 01:28
8d7ffe0 to
70cd7ad
Compare
kara
changed the title
kara
added
area: core
Contributor
Author
kara
added
the
action: review
kara
marked this pull request as ready for review
May 21, 2019 02:04
Contributor
|
Refactoring means functionality and especially API surface doesn't change. What you are doing is a |
IgorMinar
approved these changes
May 21, 2019
IgorMinar
left a comment
IgorMinar
left a comment
Contributor
There was a problem hiding this comment.
lgtm.
confidence note: we've done research in google3 and found no references and while github has over a thousand references they all refer to vendored angular d.ts files. We don't think that anyone is really using these apis and they just take up space and confuse people.
Contributor
|
I updated #30400 to reflect this change |
kara
added
action: merge
Contributor
Author
|
merge-assistance: Igor has global approval and I'm an owner of core |
Contributor
Author
|
@alfaproject Yeah, "refactor" doesn't seem quite right, but neither does "feature" (is it really a feature to remove something?). I think it's probably fine for the circumstances, but maybe "fix" would be better? 🤔 Edit: updated to "fix" |
BREAKING CHANGE In PR angular#19558, we fixed a bug in `TestBed.overrideProvider` where eager providers were not being instantiated correctly. However, it turned out that since this bug had been around for quite a bit, many apps were relying on the broken behavior where the providers would not be instantiated. To assist in the transition, the `TestBed.deprecatedOverrideProvider` method was temporarily introduced to mimic the old behavior so that apps would have a longer time period to migrate their code. 2 years and 3 versions later, it is time to remove the temporary method. This commit removes `TestBed.deprecatedOverrideProvider` altogether. Any usages of `TestBed.deprecatedOverrideProvider` should be replaced with `TestBed.overrideProvider`. This may mean that providers that were not created before will now be instantiated, which could mean that your tests need to provide more mocks or stubs for the dependencies of the newly instantiated providers.
kara
force-pushed
the
deprecatedOverrideProvider
branch
from
May 21, 2019 16:58
70cd7ad to
28dd132
Compare
kara
changed the title
jasonaden
pushed a commit
that referenced
this pull request
May 21, 2019
…#30576) BREAKING CHANGE In PR #19558, we fixed a bug in `TestBed.overrideProvider` where eager providers were not being instantiated correctly. However, it turned out that since this bug had been around for quite a bit, many apps were relying on the broken behavior where the providers would not be instantiated. To assist in the transition, the `TestBed.deprecatedOverrideProvider` method was temporarily introduced to mimic the old behavior so that apps would have a longer time period to migrate their code. 2 years and 3 versions later, it is time to remove the temporary method. This commit removes `TestBed.deprecatedOverrideProvider` altogether. Any usages of `TestBed.deprecatedOverrideProvider` should be replaced with `TestBed.overrideProvider`. This may mean that providers that were not created before will now be instantiated, which could mean that your tests need to provide more mocks or stubs for the dependencies of the newly instantiated providers. PR Close #30576
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
In PR #19558, we fixed a bug in
TestBed.overrideProviderwhereeager providers were not being instantiated correctly. However,
it turned out that since this bug had been around for quite a bit,
many apps were relying on the broken behavior where the providers
would not be instantiated. To assist in the transition, the
TestBed.deprecatedOverrideProvidermethod was temporarilyintroduced to mimic the old behavior so that apps would have a
longer time period to migrate their code.
2 years and 3 versions later, it is time to remove the temporary
method. This commit removes
TestBed.deprecatedOverrideProvideraltogether. Any usages of
TestBed.deprecatedOverrideProvidershould be replaced with
TestBed.overrideProvider. This may meanthat providers that were not created before will now be instantiated,
which could mean that your tests need to provide more mocks or stubs
for the dependencies of the newly instantiated providers.