Repository navigation
Conversation
matsko
added
comp: ivy
target: major
e3fef6f to
56cbc2f
Compare
4e52ce4 to
ba2ebb6
Compare
There was a problem hiding this comment.
Why not just use ngDevModeResetPerfCounters?
There was a problem hiding this comment.
Can you add a tests with the nulled value in the middle. Right now it is not clear if the fontSize just happens to be at the end or of all null values are at the end.
There was a problem hiding this comment.
Why did the indexes change +1?
There was a problem hiding this comment.
The first index (zero in this case) is reserved for map-based bindings.
There was a problem hiding this comment.
Why are you chocking if it is an array? When would it not be an array? Seems like unneeded check to me.
There was a problem hiding this comment.
Array.isArray() checks for the presence of LStylingMap. This function is called both for map-based bindings (which have a LStylingMap value) as well as prop-based bindings (which are just raw values). So both cases are needed.
There was a problem hiding this comment.
we discussed that this check is not the most efficient, https://jsperf.com/value-vs-string-comparison Not sure it is worth the trouble though.
There was a problem hiding this comment.
This only happens during debug mode. Not in the actual algorithm. I made sure of that.
There was a problem hiding this comment.
The reason why it's in the util.ts file is because the constant is in there.
There was a problem hiding this comment.
Why is this written this way rather than as a simple function syncStylingMap(...)?
There was a problem hiding this comment.
This is the only way I can have it respect the interface. The only way I can find having a function respect an interface is via it being a variable.
// works
const x: FnType = function() { }
// doesn't work
function x() { } as FnType
There was a problem hiding this comment.
| * If there any map-based entries present (which are applied to the | |
| * If there are any map-based entries present (which are applied to the |
mhevery
added
the
action: cleanup
644cd86 to
bac99d8
Compare
This patch in the second runtime change which refactors how styling bindings work in Angular. This patch refactors how map-based `[style]` and `[class]` bindings work using a new algorithm which is faster and less complex than the former one. This patch is a follow-up to an earlier refactor which enabled support for prop-based `[style.name]` and `[class.name]` bindings (see f03475c).
bac99d8 to
6b62155
Compare
matsko
added
action: merge
This fixes a collision between angular#30639 and angular#30543 where the latter added usages of @ViewChild without the static flag present, but the former made the flag required.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This patch in the second runtime change which refactors how styling
bindings work in Angular. This patch refactors how map-based
[style]and[class]bindings work using a new algorithm whichis faster and less complex than the former one.
This patch is a follow-up to an earlier refactor which enabled
support for prop-based
[style.name]and[class.name]bindings (see f03475c).