fix(core): remove deprecated annotation for TestBed.get by cexbrayat · Pull Request #30514 · angular/angular

cexbrayat · 2019-05-16T15:41:20Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: #29905 and FW-1336

What is the new behavior?

PR #29290 introduced a new TestBed.get signature and deprecated the existing one.
This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see #29905 for context), so we are temporarily removing the @deprecated annotation in favor of a plain text warning until we properly fix it.

Does this PR introduce a breaking change?

Yes
No

kara

Minor nit

kara

LGTM, though we should still get a public API review from @IgorMinar

IgorMinar

I also suggest that you rename the commit message to "fix(core): temporarily remove @deprecated jsdoc tag for a TextBed.get overload"

… overload PR angular#29290 introduced a new `TestBed.get` signature and deprecated the existing one. This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see angular#29905 for context), so we are temporarily removing the `@deprecated` annotation in favor of a plain text warning until we properly fix it. Refs angular#29905 Fixes FW-1336

cexbrayat · 2019-05-18T08:59:15Z

@IgorMinar I updated the doc to mention the TSLint issue according to your feedback and changed the commit message.

ngbot · 2019-05-20T17:52:36Z

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "ci-codefresh-bazel" is failing
     status "ci/angular: size" is failing
     status "codefresh-angular" is pending
     status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

IgorMinar · 2019-05-20T17:52:39Z

merge-assistance: ci is flaky

… overload (#30514) PR #29290 introduced a new `TestBed.get` signature and deprecated the existing one. This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see #29905 for context), so we are temporarily removing the `@deprecated` annotation in favor of a plain text warning until we properly fix it. Refs #29905 Fixes FW-1336 PR Close #30514

…ic.get overload Followup to angular#30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

…ic.get overload (#30714) Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too. PR Close #30714

angular-automatic-lock-bot · 2019-09-15T02:52:11Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

cexbrayat requested a review from a team May 16, 2019 15:41

googlebot added the cla: yes label May 16, 2019

cexbrayat force-pushed the fix/29905-test-bed-get branch from 832f78f to 4249ec7 Compare May 16, 2019 15:45

cexbrayat requested a review from a team May 16, 2019 15:45

cexbrayat mentioned this pull request May 16, 2019

New TestBed.get shows deprecation warning for abstract types and everywhere if using a strict tsconfig #29905

Closed

jasonaden added the area: core Issues related to the framework runtime label May 16, 2019

ngbot Bot added this to the needsTriage milestone May 16, 2019

kara suggested changes May 17, 2019

View reviewed changes

Comment thread packages/core/testing/src/test_bed.ts Resolved

kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels May 17, 2019

kara assigned cexbrayat May 17, 2019

cexbrayat force-pushed the fix/29905-test-bed-get branch from 4249ec7 to 9b11f49 Compare May 17, 2019 18:51

cexbrayat removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 17, 2019

cexbrayat requested a review from kara May 17, 2019 18:55

cexbrayat removed their assignment May 17, 2019

kara approved these changes May 17, 2019

View reviewed changes

kara added action: review The PR is still awaiting reviews from at least one requested reviewer risk: medium labels May 17, 2019

IgorMinar approved these changes May 18, 2019

View reviewed changes

Comment thread packages/core/testing/src/test_bed.ts Resolved

IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 18, 2019

IgorMinar modified the milestones: needsTriage, version 8 May 18, 2019

cexbrayat force-pushed the fix/29905-test-bed-get branch from 9b11f49 to 7f50ab1 Compare May 18, 2019 08:56

cexbrayat requested a review from IgorMinar May 18, 2019 08:58

cexbrayat removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 18, 2019

IgorMinar approved these changes May 20, 2019

View reviewed changes

IgorMinar added the action: merge The PR is ready for merge by the caretaker label May 20, 2019

IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 20, 2019

jasonaden added the hotlist: release-blocker label May 21, 2019

jasonaden closed this in f6bf892 May 21, 2019

cexbrayat added a commit to cexbrayat/angular that referenced this pull request May 29, 2019

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…

46abc4f

…ic.get overload Followup to angular#30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

cexbrayat mentioned this pull request May 29, 2019

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat… #30714

Closed

2 of 12 tasks

AndrewKushnir pushed a commit that referenced this pull request Jun 14, 2019

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…

6bc9c78

…ic.get overload (#30714) Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too. PR Close #30714

AndrewKushnir pushed a commit that referenced this pull request Jun 14, 2019

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…

0a7aebb

…ic.get overload (#30714) Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too. PR Close #30714

iget-master mentioned this pull request Jul 10, 2019

CHANGELOG.md shouldn't include pre-release changes? #31491

Closed

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019

Navigation Menu

Repository navigation

fix(core): remove deprecated annotation for TestBed.get - #30514

fix(core): remove deprecated annotation for TestBed.get#30514
cexbrayat wants to merge 1 commit into
angular:masterfrom
cexbrayat:fix/29905-test-bed-get

cexbrayat commented May 16, 2019

Uh oh!

kara left a comment

Uh oh!

Uh oh!

kara left a comment

Uh oh!

IgorMinar left a comment

Uh oh!

Uh oh!

cexbrayat commented May 18, 2019

Uh oh!

ngbot Bot commented May 20, 2019

Uh oh!

IgorMinar commented May 20, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Sep 15, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

cexbrayat commented May 16, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cexbrayat commented May 18, 2019

Uh oh!

ngbot Bot commented May 20, 2019

Uh oh!

IgorMinar commented May 20, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Sep 15, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants