Patch branch version of #29329 - #30470

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

The test_ivy_aot job fails on //packages/core/test/bundling/injection:symbol_test with this message:

Expected symbols in '/b/f/w/bazel-out/k8-fastbuild/bin/packages/core/test/bundling/injection/symbol_test.runfiles/angular/packages/core/test/bundling/injection/bundle.min_debug.js' did not match gold file.
   Symbol: NULL_INJECTOR => 1 extra in golden file.

This is interesting because:

• the non ivy test job doesn't seem to detect this
• the master branch PR doesn't show have this failure at all

But I would expect both to fail in the same way. It makes sense to have this failure because we do remove const NULL_INJECTOR = Injector.NULL;.

I thought there might be an extra NULL_INJECTOR in this branch, so I went I looked up for it.

Looking for NULL_INJECTOR in current #29329 (master version of this PR) gives me these locations:

• angular/packages/core/src/di/r3_injector.ts

  Line 50 in e55db3c

  let NULL_INJECTOR: Injector|undefined = undefined;

• angular/packages/core/src/render3/component.ts

  Line 88 in e55db3c

  export const NULL_INJECTOR: Injector = {

• angular/packages/core/test/bundling/injection/bundle.golden_symbols.json

  Line 48 in e55db3c

  "name": "NULL_INJECTOR"

Looking for NULL_INJECTOR in current #30470 (8.0.x version of this PR) gives me the same locations. The difference however, is that this branch includes it twice in the golden file:

  {
    "name": "NULL_INJECTOR"
  },
  {
    "name": "NULL_INJECTOR"
  },

I think these symbols are only toplevel ones, but am not sure. If that's the case, then the symbol test should never have two of them. If these symbols also include non-toplevel ones, then they should be somehow differentiated.

Either way, the test shouldn't just have two entries that are the same. I'll remove the second one for the purpose of this PR but we should fix that.

Actually, I don't think I can push it because it's in your fork. Can you remove that @alxhub?

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

merged

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}