Skip to content

Revert "fix(core): CSS sanitizer now allows parens in file names (#30322)" - #30463

Closed
alxhub wants to merge 1 commit into
angular:masterfrom
alxhub:revert-url-fix
Closed

Revert "fix(core): CSS sanitizer now allows parens in file names (#30322)"#30463
alxhub wants to merge 1 commit into
angular:masterfrom
alxhub:revert-url-fix

Conversation

@alxhub

@alxhub alxhub commented May 14, 2019

Copy link
Copy Markdown
Member

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alxhub
Revert "fix(core): CSS sanitizer now allows parens in file names (ang…
f00d21f 
…ular#30322)"

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.
@alxhub
alxhub requested review from a team May 14, 2019 21:07
@alxhub

alxhub commented May 14, 2019

Copy link
Copy Markdown
Member Author

Presubmit

@alxhub alxhub added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release area: core Issues related to the framework runtime labels May 14, 2019
@ngbot ngbot Bot added this to the needsTriage milestone May 14, 2019
@alxhub alxhub closed this in dbb150a May 14, 2019
alxhub added a commit that referenced this pull request May 14, 2019
@alxhub
Revert "fix(core): CSS sanitizer now allows parens in file names (#30322
db64b01 
)" (#30463)

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.

PR Close #30463
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@alxhub @BioPhoton
Revert "fix(core): CSS sanitizer now allows parens in file names (ang…
27f0989 
…ular#30322)" (angular#30463)

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.

PR Close angular#30463
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kara kara kara approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@alxhub @kara @googlebot