Conversation
gkalpak
added
action: merge
Add some recommended config files to use (as is or as basis) for setting up [remote development using docker containers][1] with VSCode. This is an opt-in feature. See `.devcontainer/README.md` for more info. The configuration can be further tweaked/improved, but is a good starting point. [1]: https://code.visualstudio.com/docs/remote/containers
4caa0f1 to
6af62c3
Compare
| @@ -0,0 +1,22 @@ | |||
| # Image metadata and config. | |||
| FROM circleci/node:10-browsers | |||
There was a problem hiding this comment.
WDYT of eventually moving to a non-circleci image? These have some specific circleci stuff going on and it would be less surprising to use the official images.
There was a problem hiding this comment.
Definitely an option. The good thing about the CircleCI ones is that they set up things to run in a headless container environment (e.g. installing Chrome and creating an alias that runs with the necessary flags to work inside a container, installing Xvfb and setting it up to automatically start when running the container, etc.). Plus, it will be similar with our CI environment.
All of this could be replicated independently (that's what I tried to do initially). But at some point I thought that if I'm re-implementing many of their stuff, I could as well use their image 😁
| "dockerFile": "Dockerfile", | ||
| "appPort": [4000, 4200, 4433, 5000, 8080, 9876], | ||
| "postCreateCommand": "yarn install", | ||
| "extensions": [ |
There was a problem hiding this comment.
Are all these mandatory? If I read the reference correctly they will all be installed. But these aren't the ones listed in https://github.com/angular/angular/blob/master/.vscode/extensions.json.
There was a problem hiding this comment.
Yeah, I was unsure about that. The two extra extensions are eslint and Angular Language Service. These are mostly useful for aio development.
I was pondering adding them to the recommended extensions, but since many people will only be developing outside aio/ I left them out.
Happy to remove them.
Maybe I can comment them out and mention that these are useful if you are working on aio/.
There was a problem hiding this comment.
I commented them out.
I, also, added them in .vscode/extension.json (also commented out, so they won't be recommended, but if someone looks inside the file they will see them).
There was a problem hiding this comment.
I think that makes sense. To be honest we're going to run more into this problem (optional extensions) as we further add more to the monorepo.
alxhub
added
the
action: review
IgorMinar
added
merge: caretaker note
|
merge-assistance: codefresh is flaky |
…0450) Add some recommended config files to use (as is or as basis) for setting up [remote development using docker containers][1] with VSCode. This is an opt-in feature. See `.devcontainer/README.md` for more info. The configuration can be further tweaked/improved, but is a good starting point. [1]: https://code.visualstudio.com/docs/remote/containers PR Close #30450
…gular#30450) Add some recommended config files to use (as is or as basis) for setting up [remote development using docker containers][1] with VSCode. This is an opt-in feature. See `.devcontainer/README.md` for more info. The configuration can be further tweaked/improved, but is a good starting point. [1]: https://code.visualstudio.com/docs/remote/containers PR Close angular#30450
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Add some recommended config files to use (as is or as basis) for setting up remote development using docker containers with VSCode. This is an opt-in feature. See
.devcontainer/README.mdfor more info.The configuration can be further tweaked/improved, but is a good starting point.