Skip to content

fix(bazel): Use existing npm/yarn lock files - #30438

Closed
kyliau wants to merge 1 commit into
angular:masterfrom
kyliau:npminstall
Closed

fix(bazel): Use existing npm/yarn lock files#30438
kyliau wants to merge 1 commit into
angular:masterfrom
kyliau:npminstall

Conversation

@kyliau

@kyliau kyliau commented May 13, 2019

Copy link
Copy Markdown
Contributor

This PR fixes Bazel builder to create yarn_install rule in WORKSPACE if
yarn.lock is present, otherwise npm_install rule if package-lock.json is
present. If none is present, default to yarn_install and create an empty
yarn.lock file.

PR closes #30164
PR closes #30359

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Keen Yee Liau
fix(bazel): Use existing npm/yarn lock files
17e640a 
This PR fixes Bazel builder to create yarn_install rule in WORKSPACE if
yarn.lock is present, otherwise npm_install rule if package-lock.json is
present. If none is present, default to yarn_install and create an empty
yarn.lock file.

PR closes angular#30164
PR closes angular#30359
@kyliau
kyliau requested a review from a team May 13, 2019 21:47
alan-agius4
alan-agius4 approved these changes May 14, 2019
View reviewed changes

@alan-agius4 alan-agius4 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kyliau kyliau added area: bazel Issues related to the published `@angular/bazel` build rules target: patch This PR is targeted for the next patch release labels May 14, 2019
@ngbot ngbot Bot added this to the needsTriage milestone May 14, 2019
@kyliau kyliau added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 14, 2019
@ngbot ngbot Bot added the action: merge The PR is ready for merge by the caretaker label May 14, 2019
@kyliau

kyliau commented May 14, 2019

Copy link
Copy Markdown
Contributor Author

Caretaker: Failure on CodeFresh is unrelated to this PR.

@ngbot

ngbot Bot commented May 14, 2019

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "angular" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alxhub alxhub closed this in ff29ccc May 14, 2019
alxhub pushed a commit that referenced this pull request May 14, 2019
Keen Yee Liau @alxhub
fix(bazel): Use existing npm/yarn lock files (#30438)
3136d9f 
This PR fixes Bazel builder to create yarn_install rule in WORKSPACE if
yarn.lock is present, otherwise npm_install rule if package-lock.json is
present. If none is present, default to yarn_install and create an empty
yarn.lock file.

PR closes #30164
PR closes #30359

PR Close #30438
@kyliau
kyliau deleted the npminstall branch May 14, 2019 18:45
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
Keen Yee Liau @BioPhoton
fix(bazel): Use existing npm/yarn lock files (angular#30438)
a327074 
This PR fixes Bazel builder to create yarn_install rule in WORKSPACE if
yarn.lock is present, otherwise npm_install rule if package-lock.json is
present. If none is present, default to yarn_install and create an empty
yarn.lock file.

PR closes angular#30164
PR closes angular#30359

PR Close angular#30438
@iget-master iget-master mentioned this pull request Jul 10, 2019
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

@angular/bazel always generates WORKSPACE with yarn_install even if ng used npm

3 participants

@kyliau @alan-agius4 @googlebot