Skip to content

fix(bazel): create empty yarn.lock if it does not exist #30359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kyliau wants to merge 1 commit into from
Closed

fix(bazel): create empty yarn.lock if it does not exist #30359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/bazel/src/schematics/ng-add/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ function addDevDependenciesToPackageJson(options: Schema) {
*/
function addFilesRequiredByBazel(options: Schema) {
return (host: Tree) => {
if (!host.exists('yarn.lock')) {
// yarn.lock is required by the yarn_install rule in the WORKSPACE.
host.create('yarn.lock', '');
}
return mergeWith(apply(url('./files'), [
applyTemplates({}),
]));
Expand Down
15 changes: 15 additions & 0 deletions packages/bazel/src/schematics/ng-add/index_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,21 @@ describe('ng-add schematic', () => {
expect(files).not.toContain('/BUILD.bazel');
});

it('should create yarn.lock if it does not exist', () => {
host = schematicRunner.runSchematic('ng-add', defaultOptions, host);
expect(host.files).toContain('/yarn.lock');
expect(host.readContent('/yarn.lock')).toBe('');
});

it('should not overwrite existing yarn.lock', () => {
expect(host.exists('/yarn.lock')).toBe(false);
host.create('/yarn.lock', 'lock file content');
expect(host.files).toContain('/yarn.lock');
host = schematicRunner.runSchematic('ng-add', defaultOptions, host);
expect(host.files).toContain('/yarn.lock');
expect(host.readContent('/yarn.lock')).toBe('lock file content');
});

it('should produce main.dev.ts and main.prod.ts for AOT', () => {
host.create('/src/main.ts', 'generated by CLI');
host = schematicRunner.runSchematic('ng-add', defaultOptions, host);
Expand Down