Skip to content

fix(bazel): create empty yarn.lock if it does not exist - #30359

Closed
kyliau wants to merge 1 commit into
angular:masterfrom
kyliau:yarnlock
Closed

fix(bazel): create empty yarn.lock if it does not exist#30359
kyliau wants to merge 1 commit into
angular:masterfrom
kyliau:yarnlock

Conversation

@kyliau

@kyliau kyliau commented May 9, 2019

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added target: patch This PR is targeted for the next patch release area: bazel Issues related to the published `@angular/bazel` build rules labels May 9, 2019
@kyliau
kyliau requested review from a team and alan-agius4 May 9, 2019 18:27
@ngbot ngbot Bot added this to the needsTriage milestone May 9, 2019
alan-agius4
alan-agius4 approved these changes May 9, 2019
View reviewed changes

@alan-agius4 alan-agius4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeagle

alexeagle commented May 9, 2019

Copy link
Copy Markdown
Contributor

I think we should just detect npm instead

@alexeagle

alexeagle commented May 9, 2019

Copy link
Copy Markdown
Contributor

see #30164 (comment)

kyliau pushed a commit to kyliau/angular that referenced this pull request May 13, 2019
Keen Yee Liau
fix(bazel): Use existing npm/yarn lock files
17e640a 
This PR fixes Bazel builder to create yarn_install rule in WORKSPACE if
yarn.lock is present, otherwise npm_install rule if package-lock.json is
present. If none is present, default to yarn_install and create an empty
yarn.lock file.

PR closes angular#30164
PR closes angular#30359
@kyliau kyliau mentioned this pull request May 13, 2019
Closed
2 of 14 tasks
@alxhub alxhub closed this in ff29ccc May 14, 2019
alxhub pushed a commit that referenced this pull request May 14, 2019
Keen Yee Liau @alxhub
fix(bazel): Use existing npm/yarn lock files (#30438)
3136d9f 
This PR fixes Bazel builder to create yarn_install rule in WORKSPACE if
yarn.lock is present, otherwise npm_install rule if package-lock.json is
present. If none is present, default to yarn_install and create an empty
yarn.lock file.

PR closes #30164
PR closes #30359

PR Close #30438
@kyliau
kyliau deleted the yarnlock branch May 14, 2019 18:45
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
Keen Yee Liau @BioPhoton
fix(bazel): Use existing npm/yarn lock files (angular#30438)
a327074 
This PR fixes Bazel builder to create yarn_install rule in WORKSPACE if
yarn.lock is present, otherwise npm_install rule if package-lock.json is
present. If none is present, default to yarn_install and create an empty
yarn.lock file.

PR closes angular#30164
PR closes angular#30359

PR Close angular#30438
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@kyliau @alexeagle @alan-agius4 @googlebot