Skip to content

fix(bazel): pass correct arguments to http_server in Windows - #30346

Closed
alan-agius4 wants to merge 1 commit into
angular:masterfrom
alan-agius4:protoactor-bazel
Closed

alan-agius4 wants to merge 1 commit into
angular:masterfrom
alan-agius4:protoactor-bazel

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented May 9, 2019 •

Copy link
Copy Markdown
Contributor

Under Windows, the server binary has an extension of .exe and the current logic is not handling that.

Partially addresses: #29785

@alan-agius4
alan-agius4 requested review from a team May 9, 2019 06:54
@alan-agius4 alan-agius4 added area: bazel Issues related to the published `@angular/bazel` build rules hotlist: windows-support labels May 9, 2019
@ngbot ngbot Bot added this to the needsTriage milestone May 9, 2019
@alan-agius4 alan-agius4 added PR action: time-zone target: patch This PR is targeted for the next patch release labels May 9, 2019
Under Windows, the server binary has an extension of  `.exe` and the current logic is not handling that.

Partially addresses: #29785
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label May 9, 2019
alxhub pushed a commit that referenced this pull request May 9, 2019
Under Windows, the server binary has an extension of  `.exe` and the current logic is not handling that.

Partially addresses: #29785

PR Close #30346
@alxhub alxhub closed this in 3aff79c May 9, 2019
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
…#30346)

Under Windows, the server binary has an extension of  `.exe` and the current logic is not handling that.

Partially addresses: angular#29785

PR Close angular#30346
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants