Repository navigation
BACKPORT TO PATCH - fix(ivy): ngcc - handle missing entry-point dependencies better - #30323
Closed
petebacondarwin wants to merge 1 commit into
Closed
petebacondarwin wants to merge 1 commit into
petebacondarwin wants to merge 1 commit into
Conversation
If an entry-point has a missing dependency then all the entry-points that would have pointed to that dependency are also removed from the dependency graph. Previously we were still processing the dependencies of an entry-point even if it had already been removed from the graph because it depended upon a missing dependency that had previously been removed due to another entry-point depending upon it. This caused the dependency processing to crash rather than gracefully logging and handling the missing invalid entry-point. Fixes angular#29624
petebacondarwin
added
type: bug/fix
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caretaker: This is a backport to patch of #30270 so it has been reviewed and presubmitted already.