Skip to content

fix(core): CSS sanitizer now allows parens in file names - #30322

Closed
benlesh wants to merge 1 commit into
angular:masterfrom
benlesh:fix-css-url-sanitization
Closed

benlesh wants to merge 1 commit into
angular:masterfrom
benlesh:fix-css-url-sanitization

Conversation

@benlesh

@benlesh benlesh commented May 8, 2019

Copy link
Copy Markdown
Contributor

Resolves an issue where images that were created with a name like 'foo (1).png' would not pass CSS url sanitization.

Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization.
@benlesh benlesh added type: bug/fix freq1: low area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release risk: low labels May 8, 2019
@ngbot ngbot Bot modified the milestone: needsTriage May 8, 2019
@benlesh
benlesh marked this pull request as ready for review May 8, 2019 02:51
@benlesh
benlesh requested review from a team May 8, 2019 02:51
@benlesh

benlesh commented May 8, 2019

Copy link
Copy Markdown
Contributor Author

presubmit

@benlesh benlesh added the action: merge The PR is ready for merge by the caretaker label May 8, 2019
@alxhub

alxhub commented May 8, 2019

Copy link
Copy Markdown
Member

Working presubmit link

@alxhub

alxhub commented May 8, 2019

Copy link
Copy Markdown
Member

A better presubmit

alxhub pushed a commit that referenced this pull request May 8, 2019
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization.

PR Close #30322
@alxhub alxhub closed this May 8, 2019
alxhub pushed a commit that referenced this pull request May 8, 2019
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization.

PR Close #30322
alxhub added a commit to alxhub/angular that referenced this pull request May 14, 2019
…ular#30322)"

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.
alxhub added a commit that referenced this pull request May 14, 2019
)" (#30463)

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.

PR Close #30463
alxhub added a commit that referenced this pull request May 14, 2019
)" (#30463)

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.

PR Close #30463
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization.

PR Close angular#30322
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
…ular#30322)" (angular#30463)

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.

PR Close angular#30463
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes freq1: low risk: low target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants