Repository navigation
Conversation
… button (angular#30160)" This reverts commit 3327bd8.
jasonaden
added
action: merge
Contributor
Author
|
|
alxhub
pushed a commit
that referenced
this pull request
May 8, 2019
jasonaden
added a commit
to jasonaden/angular
that referenced
this pull request
May 8, 2019
… to back button (angular#30160)" (angular#30320)" This reverts commit 8ced321.
alxhub
pushed a commit
that referenced
this pull request
May 15, 2019
alxhub
pushed a commit
that referenced
this pull request
May 15, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
… button (angular#30160)" (angular#30320) This reverts commit 3327bd8. PR Close angular#30320
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
… to back button (angular#30160)" (angular#30320)" (angular#30344) This reverts commit 8ced321. PR Close angular#30344
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… button (#30160)"
This reverts commit 3327bd8.
This is being reverted because of a test failure in Google.
The test navigates to a route, then navigates to the same route again, which in the router codebase falls into a path that essentially marks it to do nothing. Upon marking it to do nothing, we attempt to get the state right for the next navigation. The second navigation had been kicked off using a value from
this.transitions, which doesn't actually have the previousurlAfterRedirectsvalue.So the next navigation they are performing in the test is hitting
back, which goes to the root. Because they happened to start on root, then navigate twice to the same place, then specifically gobackto the root again, thebackoperation does nothing because the router thinks it’s already there.The fix to this should be ensuring
Router.getTransition()method returns the most recentNavigationTransitionafter all changes have been applied to it (the value that lands in thesubscribeonthis.navigations).