Repository navigation
Windows ngcc infinite loop and tests under windows - #30297
Closed
alan-agius4 wants to merge 6 commits into
Closed
alan-agius4 wants to merge 6 commits into
alan-agius4 wants to merge 6 commits into
Conversation
alan-agius4
added
hotlist: windows-support
action: cleanup
alan-agius4
marked this pull request as ready for review
May 7, 2019 08:08
alan-agius4
removed
the
action: cleanup
alan-agius4
changed the title
alan-agius4
added
comp: ivy
target: major
Contributor
Author
|
Supersedes #30212 since there are new commits to fix the integration tests in Windows |
Contributor
Author
|
//cc @meteorcloudy |
meteorcloudy
reviewed
May 7, 2019
gkalpak
approved these changes
May 7, 2019
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
One minor comment. LGTM otherwise.
alan-agius4
commented
May 7, 2019
alxhub
approved these changes
May 7, 2019
Member
There was a problem hiding this comment.
Let's go ahead and delete fromUnchecked if it's not used.
Contributor
Author
There was a problem hiding this comment.
It still used in a couple of places.
Member
alan-agius4
added
action: presubmit
Contributor
alan-agius4
added
action: merge
At the moment the module resolver will end up in an infinite loop in Windows because we are assuming that the root directory is always `/` however in windows this can be any drive letter example `c:/` or `d:/` etc... With this change we also resolve the drive letter in windows, when using `AbsoluteFsPath.from` for consistence so under `/foo` will be converted to `c:/foo` this is also needed because of relative paths with different drive letters.
``` //packages/compiler-cli/ngcc/test:test ``` Partially addresses #29785
``` //packages/compiler-cli/ngcc/test:integration ``` Partially addresses #29785
alxhub
pushed a commit
that referenced
this pull request
May 13, 2019
alxhub
pushed a commit
that referenced
this pull request
May 13, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
At the moment the module resolver will end up in an infinite loop in Windows because we are assuming that the root directory is always `/` however in windows this can be any drive letter example `c:/` or `d:/` etc... With this change we also resolve the drive letter in windows, when using `AbsoluteFsPath.from` for consistence so under `/foo` will be converted to `c:/foo` this is also needed because of relative paths with different drive letters. PR Close angular#30297
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
``` //packages/compiler-cli/ngcc/test:test ``` Partially addresses angular#29785 PR Close angular#30297
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
``` //packages/compiler-cli/ngcc/test:integration ``` Partially addresses angular#29785 PR Close angular#30297
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ivy): handle windows drives correctly
At the moment the module resolver will end up in an infinite loop in Windows because we are assuming that the root directory is always / however in windows this can be any drive letter example c:/ or d:/ etc...
With this change we also resolve the drive letter in windows, when using AbsoluteFsPath.from for consistence so under /foo will be converted to c:/foo this is also needed because of relative paths with different drive letters.
This also fixes these test targets
Partially addresses #29785