Skip to content

fix(compiler-cli): log ngcc skipping messages as debug instead of inf… #30289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filipesilva wants to merge 1 commit into from
Closed

fix(compiler-cli): log ngcc skipping messages as debug instead of inf… #30289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration/ngcc/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ if [[ $? != 0 ]]; then exit 1; fi

# Can it be safely run again (as a noop)?
# And check that it logged skipping compilation as expected
ivy-ngcc | grep 'Skipping'
ivy-ngcc -l debug | grep 'Skipping'
if [[ $? != 0 ]]; then exit 1; fi

# Check that running it with logging level error outputs nothing
Expand Down
6 changes: 3 additions & 3 deletions packages/compiler-cli/ngcc/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export function mainNgcc({basePath, targetEntryPointPath,
if (absoluteTargetEntryPointPath &&
hasProcessedTargetEntryPoint(
absoluteTargetEntryPointPath, propertiesToConsider, compileAllFormats)) {
logger.info('The target entry-point has already been processed');
logger.debug('The target entry-point has already been processed');
return;
}

Expand Down Expand Up @@ -131,7 +131,7 @@ export function mainNgcc({basePath, targetEntryPointPath,

if (hasBeenProcessed(entryPointPackageJson, property)) {
compiledFormats.add(formatPath);
logger.info(`Skipping ${entryPoint.name} : ${property} (already compiled).`);
logger.debug(`Skipping ${entryPoint.name} : ${property} (already compiled).`);
continue;
}

Expand All @@ -153,7 +153,7 @@ export function mainNgcc({basePath, targetEntryPointPath,
`Skipping ${entryPoint.name} : ${format} (no valid entry point file for this format).`);
}
} else if (!compileAllFormats) {
logger.info(`Skipping ${entryPoint.name} : ${property} (already compiled).`);
logger.debug(`Skipping ${entryPoint.name} : ${property} (already compiled).`);
}

// Either this format was just compiled or its underlying format was compiled because of a
Expand Down
8 changes: 4 additions & 4 deletions packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describe('ngcc main()', () => {
basePath: '/node_modules',
targetEntryPointPath: '@angular/common/http/testing', logger,
});
expect(logger.logs.info).toContain(['The target entry-point has already been processed']);
expect(logger.logs.debug).toContain(['The target entry-point has already been processed']);
});

it('should process the target if any `propertyToConsider` is not marked as processed', () => {
Expand All @@ -110,7 +110,7 @@ describe('ngcc main()', () => {
targetEntryPointPath: '@angular/common/http/testing',
propertiesToConsider: ['fesm2015', 'esm5', 'esm2015'], logger,
});
expect(logger.logs.info).not.toContain([
expect(logger.logs.debug).not.toContain([
'The target entry-point has already been processed'
]);
});
Expand All @@ -128,7 +128,7 @@ describe('ngcc main()', () => {
compileAllFormats: false, logger,
});

expect(logger.logs.info).not.toContain([
expect(logger.logs.debug).not.toContain([
'The target entry-point has already been processed'
]);
});
Expand All @@ -145,7 +145,7 @@ describe('ngcc main()', () => {
compileAllFormats: false, logger,
});

expect(logger.logs.info).toContain([
expect(logger.logs.debug).toContain([
'The target entry-point has already been processed'
]);
});
Expand Down