Repository navigation
fix(ngcc): do not crash if missing entry-point dependencies - #30270
Closed
petebacondarwin wants to merge 3 commits into
Closed
petebacondarwin wants to merge 3 commits into
petebacondarwin wants to merge 3 commits into
Conversation
petebacondarwin
force-pushed
the
issue-29624
branch
2 times, most recently
from
May 5, 2019 15:03
330bf8f to
bf202d4
Compare
petebacondarwin
commented
May 6, 2019
petebacondarwin
force-pushed
the
issue-29624
branch
2 times, most recently
from
May 6, 2019 21:15
f3c8653 to
a6cd03b
Compare
petebacondarwin
changed the title
gkalpak
approved these changes
May 7, 2019
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
Commit message typo: "Previously we still processing"
gkalpak
added
the
action: cleanup
If an entry-point has a missing dependency then all the entry-points that would have pointed to that dependency are also removed from the dependency graph. Previously we were still processing the dependencies of an entry-point even if it had already been removed from the graph because it depended upon a missing dependency that had previously been removed due to another entry-point depending upon it. This caused the dependency processing to crash rather than gracefully logging and handling the missing invalid entry-point. Fixes angular#29624
petebacondarwin
force-pushed
the
issue-29624
branch
from
May 7, 2019 10:16
a6cd03b to
8464c9f
Compare
petebacondarwin
added
action: merge
kara
added
target: major
Contributor
|
@petebacondarwin Can you make a patch-only version of this PR? It doesn't apply cleanly. |
kara
pushed a commit
that referenced
this pull request
May 7, 2019
If an entry-point has a missing dependency then all the entry-points that would have pointed to that dependency are also removed from the dependency graph. Previously we were still processing the dependencies of an entry-point even if it had already been removed from the graph because it depended upon a missing dependency that had previously been removed due to another entry-point depending upon it. This caused the dependency processing to crash rather than gracefully logging and handling the missing invalid entry-point. Fixes #29624 PR Close #30270
Contributor
Author
|
Done here #30323 |
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…lar#30270) If an entry-point has a missing dependency then all the entry-points that would have pointed to that dependency are also removed from the dependency graph. Previously we were still processing the dependencies of an entry-point even if it had already been removed from the graph because it depended upon a missing dependency that had previously been removed due to another entry-point depending upon it. This caused the dependency processing to crash rather than gracefully logging and handling the missing invalid entry-point. Fixes angular#29624 PR Close angular#30270
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29624