Repository navigation
fix(compiler-cli): log ngcc skipping messages as debug instead of info - #30232
Closed
filipesilva wants to merge 1 commit into
Closed
filipesilva wants to merge 1 commit into
filipesilva wants to merge 1 commit into
Conversation
|
You can preview dbee62e at https://pr30232-dbee62e.ngbuilds.io/. |
petebacondarwin
approved these changes
May 2, 2019
petebacondarwin
added
area: core
alan-agius4
approved these changes
May 2, 2019
|
You can preview 820db13 at https://pr30232-820db13.ngbuilds.io/. |
petebacondarwin
added
target: patch
Contributor
|
Added |
kara
added
target: major
Contributor
|
@filipesilva This doesn't apply cleanly to the patch branch. Can you create a separate PR for the patch branch? |
Contributor
Author
kara
pushed a commit
that referenced
this pull request
May 6, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ngcc messages related to skipping are logged to info, which makes it hard to filter them out.
What is the new behavior?
ngcc messages related to skipping are logged to debug instead of info.
Does this PR introduce a breaking change?
Other information
Related to angular/angular-cli#14194, angular/angular-cli#14320