Repository navigation
Windows ngcc infinite loop - #30212
Closed
alan-agius4 wants to merge 3 commits into
Closed
alan-agius4 wants to merge 3 commits into
alan-agius4 wants to merge 3 commits into
Conversation
alan-agius4
added
area: core
alan-agius4
added
the
action: review
At the moment the module resolver will end up in an infinite loop in Windows because we are assuming that the root directory is always `/` however in windows this can be any drive letter example `c:/` or `d:/` etc... With this change we also resolve the drive letter in windows, when using `AbsoluteFsPath.from` for consistence so under `/foo` will be converted to `c:/foo` this is also needed because of relative paths with different drive letters.
``` //packages/compiler-cli/ngcc/test:test ``` Partially addresses #29785
petebacondarwin
approved these changes
May 1, 2019
Contributor
Author
|
Superseded by #30297 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ivy): handle windows drives correctly
At the moment the module resolver will end up in an infinite loop in Windows because we are assuming that the root directory is always
/however in windows this can be any drive letter examplec:/ord:/etc...With this change we also resolve the drive letter in windows, when using
AbsoluteFsPath.fromfor consistence so under/foowill be converted toc:/foothis is also needed because of relative paths with different drive letters.test: fix ngcc unit tests in windows
Partially addresses #29785