Repository navigation
test: fix several bazel compiler-cli tests in windows - #30189
Closed
alan-agius4 wants to merge 3 commits into
Closed
alan-agius4 wants to merge 3 commits into
alan-agius4 wants to merge 3 commits into
Conversation
alan-agius4
added
area: core
|
|
alan-agius4
added
area: build & ci
``` //packages/compiler-cli/integrationtest:integrationtest //packages/compiler-cli/test/compliance:compliance ``` Partially addresses #29785
devversion
approved these changes
May 6, 2019
devversion
left a comment
devversion
left a comment
Member
There was a problem hiding this comment.
LGTM for dev-infra.
Also the changes in general look good to me 😄 I did similar stuff in 40d64b6 to get it work on windows.
gkalpak
reviewed
May 7, 2019
alxhub
approved these changes
May 7, 2019
kara
pushed a commit
that referenced
this pull request
May 7, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
``` //packages/compiler-cli/integrationtest:integrationtest //packages/compiler-cli/test/compliance:compliance ``` Partially addresses angular#29785 PR Close angular#30189
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #29785