Repository navigation
Conversation
Without this change, `history.state` isn't being set when updating the browser URL in `eager` update mode.
jasonaden
added
action: merge
Contributor
Author
mhevery
approved these changes
Apr 26, 2019
Contributor
|
@jasonaden Can you look at the TAP failures here? |
kara
added
the
action: cleanup
jasonaden
removed
the
action: cleanup
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…gular#30154) Without this change, `history.state` isn't being set when updating the browser URL in `eager` update mode. PR Close angular#30154
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change,
history.stateisn't being set when updating the browser URL ineagerupdate mode.