Repository navigation
test: fix ngc compiler tests under windows - #30146
Closed
alan-agius4 wants to merge 2 commits into
Closed
alan-agius4 wants to merge 2 commits into
alan-agius4 wants to merge 2 commits into
Conversation
alan-agius4
added
area: build & ci
alan-agius4
marked this pull request as ready for review
April 26, 2019 13:29
filipesilva
approved these changes
Apr 26, 2019
alan-agius4
added
target: patch
alxhub
approved these changes
May 7, 2019
alan-agius4
added
merge: caretaker note
This comment has been minimized.
This comment has been minimized.
alan-agius4
removed
merge: caretaker note
Member
``` //packages/compiler-cli/test:ngc //packages/compiler/test:test ``` This also address `node_modules` to the ignored paths for ngc compiler as otherwise the `ready` is never fired Partially addresses #29785
This commit fixes the following test target in windows ``` //packages/compiler-cli/test/ngtsc:ngtsc ```
Contributor
alan-agius4
added
action: merge
alxhub
pushed a commit
that referenced
this pull request
May 13, 2019
alxhub
pushed a commit
that referenced
this pull request
May 13, 2019
This commit fixes the following test target in windows ``` //packages/compiler-cli/test/ngtsc:ngtsc ``` PR Close #30146
alxhub
pushed a commit
that referenced
this pull request
May 13, 2019
This commit fixes the following test target in windows ``` //packages/compiler-cli/test/ngtsc:ngtsc ``` PR Close #30146
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
``` //packages/compiler-cli/test:ngc //packages/compiler/test:test ``` This also address `node_modules` to the ignored paths for ngc compiler as otherwise the `ready` is never fired Partially addresses angular#29785 PR Close angular#30146
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
This commit fixes the following test target in windows ``` //packages/compiler-cli/test/ngtsc:ngtsc ``` PR Close angular#30146
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: fix several Bazel compiler tests in windows
This also address
node_modulesto the ignored paths for ngc compiler as otherwise thereadyis never firedPartially addresses #29785