Skip to content

fix(bazel): Exclude common/upgrade* in metadata.tsconfig.json - #30133

Closed
kyliau wants to merge 1 commit into
angular:masterfrom
kyliau:upgrade
Closed

kyliau wants to merge 1 commit into
angular:masterfrom
kyliau:upgrade

Conversation

@kyliau

@kyliau kyliau commented Apr 25, 2019

Copy link
Copy Markdown
Contributor

It has a dependency on @angular/upgrade which is not part of the
dependencies in package.json, so postinstall would fail.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Apr 25, 2019
@kyliau
kyliau requested review from a team and alexeagle April 25, 2019 23:40
@ngbot ngbot Bot added this to the needsTriage milestone Apr 25, 2019
@kyliau
kyliau requested a review from a team April 26, 2019 00:03
It has a dependency on @angular/upgrade which is not part of the
dependencies in package.json, so postinstall would fail.
@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Apr 26, 2019
@IgorMinar IgorMinar modified the milestones: needsTriage, version 8 Apr 26, 2019
@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Apr 26, 2019
@alexeagle alexeagle added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 26, 2019
AndrewKushnir pushed a commit that referenced this pull request Apr 26, 2019
It has a dependency on @angular/upgrade which is not part of the
dependencies in package.json, so postinstall would fail.

PR Close #30133
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
…r#30133)

It has a dependency on @angular/upgrade which is not part of the
dependencies in package.json, so postinstall would fail.

PR Close angular#30133
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
@kyliau
kyliau deleted the upgrade branch October 16, 2019 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants