Skip to content

test: fix ngc-wrapped bazel tests in windows - #30111

Closed
alan-agius4 wants to merge 1 commit into
angular:masterfrom
alan-agius4:ngc-wrapped_bazel_test_windows
Closed

alan-agius4 wants to merge 1 commit into
angular:masterfrom
alan-agius4:ngc-wrapped_bazel_test_windows

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Apr 25, 2019 •

Copy link
Copy Markdown
Contributor

Fixes the below target in windows

//packages/bazel/test/ngc-wrapped:ngc_test

Partially addresses #29785

@alan-agius4
alan-agius4 requested a review from a team April 25, 2019 12:17
@alan-agius4 alan-agius4 added area: build & ci Related the build and CI infrastructure of the project hotlist: windows-support target: major This PR is targeted for the next major release labels Apr 25, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Apr 25, 2019
@alan-agius4 alan-agius4 added the area: bazel Issues related to the published `@angular/bazel` build rules label Apr 25, 2019

@meteorcloudy meteorcloudy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but may need another look from an Angular expert. Thanks!

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Apr 26, 2019
@IgorMinar IgorMinar added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 29, 2019
@IgorMinar

Copy link
Copy Markdown
Contributor

merge-assistance: please presubmit

@AndrewKushnir

AndrewKushnir commented Apr 29, 2019 •

Copy link
Copy Markdown
Contributor

Presubmit

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Apr 29, 2019
AndrewKushnir pushed a commit that referenced this pull request Apr 29, 2019
@alan-agius4
alan-agius4 deleted the ngc-wrapped_bazel_test_windows branch April 29, 2019 20:28
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants