Repository navigation
Conversation
gkalpak
added
action: merge
In angular#29953, the wait period for SW on localhost was increased to avoid CI flakes for the PWA score tests. This commit expands the fix to non-localhost origins to avoid flakes in the `aio_monitoring` job, when CircleCI VMs/network are slow. (For reference, example failures: [289127], [289238]) [289127]: https://circleci.com/gh/angular/angular/289127 [289238]: https://circleci.com/gh/angular/angular/289238
gkalpak
force-pushed
the
ci-aio-fix-pwa-flakes
branch
from
April 19, 2019 10:11
8b0187d to
ea10345
Compare
|
You can preview 8b0187d at https://pr29988-8b0187d.ngbuilds.io/. |
|
You can preview ea10345 at https://pr29988-ea10345.ngbuilds.io/. |
petebacondarwin
approved these changes
Apr 19, 2019
benlesh
pushed a commit
that referenced
this pull request
Apr 19, 2019
#29988) In #29953, the wait period for SW on localhost was increased to avoid CI flakes for the PWA score tests. This commit expands the fix to non-localhost origins to avoid flakes in the `aio_monitoring` job, when CircleCI VMs/network are slow. (For reference, example failures: [289127], [289238]) [289127]: https://circleci.com/gh/angular/angular/289127 [289238]: https://circleci.com/gh/angular/angular/289238 PR Close #29988
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
angular#29988) In angular#29953, the wait period for SW on localhost was increased to avoid CI flakes for the PWA score tests. This commit expands the fix to non-localhost origins to avoid flakes in the `aio_monitoring` job, when CircleCI VMs/network are slow. (For reference, example failures: [289127], [289238]) [289127]: https://circleci.com/gh/angular/angular/289127 [289238]: https://circleci.com/gh/angular/angular/289238 PR Close angular#29988
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #29953, the wait period for SW on localhost was increased to avoid CI flakes for the PWA score tests.
This commit expands the fix to non-localhost origins to avoid flakes in the
aio_monitoringjob, when CircleCI VMs/network are slow.(For reference, example failures: 289127, 289238)