Repository navigation
Conversation
|
You can preview a23f677 at https://pr29953-a23f677.ngbuilds.io/. |
gkalpak
force-pushed
the
build-aio-fix-pwa-test-2
branch
from
April 17, 2019 07:17
a23f677 to
8c848d7
Compare
|
You can preview 8c848d7 at https://pr29953-8c848d7.ngbuilds.io/. |
gkalpak
force-pushed
the
build-aio-fix-pwa-test-2
branch
2 times, most recently
from
April 17, 2019 07:35
88d587e to
0a1d519
Compare
|
You can preview 88d587e at https://pr29953-88d587e.ngbuilds.io/. |
|
You can preview 0a1d519 at https://pr29953-0a1d519.ngbuilds.io/. |
gkalpak
force-pushed
the
build-aio-fix-pwa-test-2
branch
from
April 17, 2019 09:21
0a1d519 to
f30670a
Compare
This was referenced Apr 17, 2019
|
You can preview f30670a at https://pr29953-f30670a.ngbuilds.io/. |
gkalpak
added
area: build & ci
The server used for testing on localhost has less optimizations (e.g. serves uncompressed files), so we need to wait longer the ServiceWorker to be loaded and registered to allow Lighthouse to reliably detect it, especially on slower environments (e.g. CI). Related: GoogleChrome/lighthouse#5527 (comment) Fixes angular#29910
gkalpak
force-pushed
the
build-aio-fix-pwa-test-2
branch
from
April 17, 2019 09:42
f30670a to
17ea000
Compare
|
You can preview 17ea000 at https://pr29953-17ea000.ngbuilds.io/. |
gkalpak
marked this pull request as ready for review
April 17, 2019 09:48
filipesilva
approved these changes
Apr 17, 2019
| function waitLongerForSw(config) { | ||
| console.info(`Will wait longer for ServiceWorker (${LONG_WAIT_FOR_SW_DELAY}ms)...`); | ||
| const passes = config.passes || (config.passes = []); | ||
| passes.push({passName: 'defaultPass', pauseAfterLoadMs: LONG_WAIT_FOR_SW_DELAY}); |
Contributor
There was a problem hiding this comment.
What other implications are there here? I'd expect local scores to be artificially inflated because in these 5s the app loads completely.
Member
Author
There was a problem hiding this comment.
AFAICT, there are no other implications. (The score is 100% anyway as long as the SW is detected in time and the failing tests when it is not detected are boolean (does it have a SW? does it work offline? etc).)
Other categories (e.g. performance) don't seem to be inflated due to this setting (e.g. performance is still ~45% on localhost). This makes sense, because pauseAfterLoadMs does not affect performance-specific metrics (such as first-meaningful-paint).
benlesh
pushed a commit
that referenced
this pull request
Apr 17, 2019
benlesh
pushed a commit
that referenced
this pull request
Apr 17, 2019
…29953) The server used for testing on localhost has less optimizations (e.g. serves uncompressed files), so we need to wait longer the ServiceWorker to be loaded and registered to allow Lighthouse to reliably detect it, especially on slower environments (e.g. CI). Related: GoogleChrome/lighthouse#5527 (comment) Fixes #29910 PR Close #29953
benlesh
pushed a commit
that referenced
this pull request
Apr 17, 2019
…29953) The server used for testing on localhost has less optimizations (e.g. serves uncompressed files), so we need to wait longer the ServiceWorker to be loaded and registered to allow Lighthouse to reliably detect it, especially on slower environments (e.g. CI). Related: GoogleChrome/lighthouse#5527 (comment) Fixes #29910 PR Close #29953
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Apr 19, 2019
In angular#29953, the wait period for SW on localhost was increased to avoid CI flakes for the PWA score tests. This commit expands the fix to non-localhost origins to avoid flakes in the `aio_monitoring` job, when CircleCI VMs/network are slow. (For reference, example failures: [289127], [289238]) [289127]: https://circleci.com/gh/angular/angular/289127 [289238]: https://circleci.com/gh/angular/angular/289238
benlesh
pushed a commit
that referenced
this pull request
Apr 19, 2019
#29988) In #29953, the wait period for SW on localhost was increased to avoid CI flakes for the PWA score tests. This commit expands the fix to non-localhost origins to avoid flakes in the `aio_monitoring` job, when CircleCI VMs/network are slow. (For reference, example failures: [289127], [289238]) [289127]: https://circleci.com/gh/angular/angular/289127 [289238]: https://circleci.com/gh/angular/angular/289238 PR Close #29988
benlesh
pushed a commit
that referenced
this pull request
Apr 19, 2019
#29988) In #29953, the wait period for SW on localhost was increased to avoid CI flakes for the PWA score tests. This commit expands the fix to non-localhost origins to avoid flakes in the `aio_monitoring` job, when CircleCI VMs/network are slow. (For reference, example failures: [289127], [289238]) [289127]: https://circleci.com/gh/angular/angular/289127 [289238]: https://circleci.com/gh/angular/angular/289238 PR Close #29988
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ngular#29953) The server used for testing on localhost has less optimizations (e.g. serves uncompressed files), so we need to wait longer the ServiceWorker to be loaded and registered to allow Lighthouse to reliably detect it, especially on slower environments (e.g. CI). Related: GoogleChrome/lighthouse#5527 (comment) Fixes angular#29910 PR Close angular#29953
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
angular#29988) In angular#29953, the wait period for SW on localhost was increased to avoid CI flakes for the PWA score tests. This commit expands the fix to non-localhost origins to avoid flakes in the `aio_monitoring` job, when CircleCI VMs/network are slow. (For reference, example failures: [289127], [289238]) [289127]: https://circleci.com/gh/angular/angular/289127 [289238]: https://circleci.com/gh/angular/angular/289238 PR Close angular#29988
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local server is unoptimized (e.g. no compression), so wait longer for the SW to be loaded and registered to allow Lighthouse reliably detect it, especially on slower environments (e.g. CI).
Fixes #29910.