Skip to content

ci(docs-infra): temporarily lower the min required PWA score for localhost tests - #29911

Closed
gkalpak wants to merge 1 commit into
angular:masterfrom
gkalpak:ci-aio-disable-pwa-on-localhost
Closed

gkalpak wants to merge 1 commit into
angular:masterfrom
gkalpak:ci-aio-disable-pwa-on-localhost

Conversation

@gkalpak

@gkalpak gkalpak commented Apr 15, 2019

Copy link
Copy Markdown
Member

The PWA score tests have been occasionally failing on CI recently (possibly due to CI VM/network issues).

This commit temporarily disables them, until we investigate the root-cause and/or put a work-around in place.

The PWA score tests are still run against the deployed versions (which don't suffer as much) or PRs with public previews (as part of the test_aio_preview job) and on upstream builds (as part of the deploy_aio job).

Related to #29910.

…lhost tests

The PWA score tests have been occasionally failing on CI recently
(possibly due to CI VM/network issues).

This commit temporarily disables them, until we investigate the
root-cause and/or put a work-around in place.

The PWA score tests are still run against the deployed versions (which
don't suffer as much) or PRs with public previews (as part of the
`test_aio_preview` job) and on upstream builds (as part of the
`deploy_aio` job).

Related to angular#29910.

[1]: https://github.com/angular/angular/blob/3a836c362/.circleci/config.yml#L390
@gkalpak
gkalpak requested a review from a team April 15, 2019 18:52
@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project comp: docs-infra action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 15, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Apr 15, 2019
alxhub pushed a commit that referenced this pull request Apr 15, 2019
…lhost tests (#29911)

The PWA score tests have been occasionally failing on CI recently
(possibly due to CI VM/network issues).

This commit temporarily disables them, until we investigate the
root-cause and/or put a work-around in place.

The PWA score tests are still run against the deployed versions (which
don't suffer as much) or PRs with public previews (as part of the
`test_aio_preview` job) and on upstream builds (as part of the
`deploy_aio` job).

Related to #29910.

[1]: https://github.com/angular/angular/blob/3a836c362/.circleci/config.yml#L390

PR Close #29911
@alxhub alxhub closed this in 8027b3e Apr 15, 2019
@gkalpak
gkalpak deleted the ci-aio-disable-pwa-on-localhost branch April 15, 2019 19:37
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
…lhost tests (angular#29911)

The PWA score tests have been occasionally failing on CI recently
(possibly due to CI VM/network issues).

This commit temporarily disables them, until we investigate the
root-cause and/or put a work-around in place.

The PWA score tests are still run against the deployed versions (which
don't suffer as much) or PRs with public previews (as part of the
`test_aio_preview` job) and on upstream builds (as part of the
`deploy_aio` job).

Related to angular#29910.

[1]: https://github.com/angular/angular/blob/3a836c362/.circleci/config.yml#L390

PR Close angular#29911
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants