Skip to content

build(docs-infra): update to latest CLI beta - #29908

Closed
gkalpak wants to merge 3 commits into
angular:7.2.xfrom
gkalpak:7.2.x-cli-webworker
Closed

gkalpak wants to merge 3 commits into
angular:7.2.xfrom
gkalpak:7.2.x-cli-webworker

Conversation

@gkalpak

@gkalpak gkalpak commented Apr 15, 2019 •

Copy link
Copy Markdown
Member

#29764 but for the 7.2.x branch.

@gkalpak
gkalpak requested a review from a team April 15, 2019 15:46
@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@mary-poppins

Copy link
Copy Markdown

You can preview 5c83465 at https://pr29908-5c83465.ngbuilds.io/.

@gkalpak
gkalpak force-pushed the 7.2.x-cli-webworker branch from 38dcd07 to b0b4de7 Compare April 15, 2019 16:53
@mary-poppins

Copy link
Copy Markdown

You can preview b0b4de7 at https://pr29908-b0b4de7.ngbuilds.io/.

@gkalpak gkalpak changed the title 7.2.x cli webworker build(docs-infra): update to latest CLI beta Apr 15, 2019
@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project comp: docs-infra action: merge The PR is ready for merge by the caretaker and removed state: WIP labels Apr 15, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Apr 15, 2019
@ngbot

ngbot Bot commented Apr 15, 2019

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "cla/google" is failing
    pending missing required labels: cla: yes
    pending forbidden labels detected: cla: no

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@gkalpak gkalpak added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 15, 2019
@gkalpak

gkalpak commented Apr 15, 2019

Copy link
Copy Markdown
Member Author

merge-assistance: Requires manual CLA verification.

@alxhub alxhub added cla: yes and removed cla: no labels Apr 15, 2019
@googlebot

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

alxhub pushed a commit that referenced this pull request Apr 15, 2019
alxhub pushed a commit that referenced this pull request Apr 15, 2019
@gkalpak

gkalpak commented Apr 15, 2019

Copy link
Copy Markdown
Member Author

Merged as cd2a2f7 and e5cbc9b.

@gkalpak gkalpak closed this Apr 15, 2019
@gkalpak
gkalpak deleted the 7.2.x-cli-webworker branch April 15, 2019 18:31
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants