Repository navigation
Conversation
petebacondarwin
approved these changes
Apr 11, 2019
cexbrayat
force-pushed
the
fix/ng-domain
branch
from
April 25, 2019 13:55
96b3b76 to
6716210
Compare
Currently, in jit mode, `ngInjectableDef`, `ngDirectiveDef`, `ngPipeDef` and `ngModuleDef` use `ng://`, which display them in the top domain in Chrome Dev Tools, whereas `ngComponentDef` uses `ng:///` which display components in a separate domain. You can currently see: ``` AppModule UserService ng:// |_ AppComponent |_ template.html |_ AppComponent.js ... ``` This commits replaces all `ng://` with `ng:///` to display every Angular entity in the `ng://` domain. ``` ng:// |_ AppModule |_ UserService |_ AppComponent ... ```
petebacondarwin
added
action: review
kara
added
target: major
Contributor
kara
pushed a commit
that referenced
this pull request
May 7, 2019
Currently, in jit mode, `ngInjectableDef`, `ngDirectiveDef`, `ngPipeDef` and `ngModuleDef` use `ng://`, which display them in the top domain in Chrome Dev Tools, whereas `ngComponentDef` uses `ng:///` which display components in a separate domain. You can currently see: ``` AppModule UserService ng:// |_ AppComponent |_ template.html |_ AppComponent.js ... ``` This commits replaces all `ng://` with `ng:///` to display every Angular entity in the `ng://` domain. ``` ng:// |_ AppModule |_ UserService |_ AppComponent ... ``` PR Close #29826
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
Currently, in jit mode, `ngInjectableDef`, `ngDirectiveDef`, `ngPipeDef` and `ngModuleDef` use `ng://`, which display them in the top domain in Chrome Dev Tools, whereas `ngComponentDef` uses `ng:///` which display components in a separate domain. You can currently see: ``` AppModule UserService ng:// |_ AppComponent |_ template.html |_ AppComponent.js ... ``` This commits replaces all `ng://` with `ng:///` to display every Angular entity in the `ng://` domain. ``` ng:// |_ AppModule |_ UserService |_ AppComponent ... ``` PR Close angular#29826
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, in jit mode,
ngInjectableDef,ngDirectiveDef,ngPipeDefandngModuleDefuseng://,which display them in the top domain in Chrome Dev Tools, whereas
ngComponentDefusesng:///which display components in a separate domain.You can currently see:
What is the new behavior?
This commits replaces all
ng://withng:///to display every Angular entity in theng://domain.Does this PR introduce a breaking change?
Other information
Note that this was already the case in VE:
angular/packages/compiler/src/compile_metadata.ts
Lines 707 to 711 in 19afb79