Skip to content

build: Fix label name - #29777

Closed
meteorcloudy wants to merge 1 commit into
angular:masterfrom
meteorcloudy:patch-1
Closed

build: Fix label name#29777
meteorcloudy wants to merge 1 commit into
angular:masterfrom
meteorcloudy:patch-1

Conversation

@meteorcloudy

@meteorcloudy meteorcloudy commented Apr 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix the following error with future Bazel version:

 Invalid label: invalid target name 'internal/npm_package:npm_package.bzl': target names may not contain ':'

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@meteorcloudy
meteorcloudy requested a review from a team April 9, 2019 09:29
@meteorcloudy

meteorcloudy commented Apr 9, 2019

Copy link
Copy Markdown
Contributor Author

@alexeagle

@meteorcloudy meteorcloudy mentioned this pull request Apr 9, 2019
Closed
3 tasks
alexeagle
alexeagle approved these changes Apr 11, 2019
View reviewed changes

@alexeagle alexeagle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update your commit message to start with build: to fix the red lint?

@alexeagle alexeagle added the area: bazel Issues related to the published `@angular/bazel` build rules label Apr 11, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Apr 11, 2019
@meteorcloudy
build: Fix label name
d8ff331 
Fix the following error with future Bazel version:
```
 Invalid label: invalid target name 'internal/npm_package:npm_package.bzl': target names may not contain ':'
```
@meteorcloudy

meteorcloudy commented Apr 11, 2019

Copy link
Copy Markdown
Contributor Author

Done.

@alexeagle alexeagle added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker labels Apr 16, 2019
@alxhub alxhub closed this in ca755a6 Apr 16, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@meteorcloudy @wKoza
build: Fix label name (angular#29777)
97a8007 
Fix the following error with future Bazel version:
```
 Invalid label: invalid target name 'internal/npm_package:npm_package.bzl': target names may not contain ':'
```

PR Close angular#29777
@LinboLen

LinboLen commented May 11, 2019

Copy link
Copy Markdown

Skipping '//libs/project:npm_package': error loading package 'libs/project': in /project/tools/defaults.bzl: in /private/var/tmp/_bazel_x/41ad1bbbf8ac7656dcafc83d22406997/external/npm_angular_bazel/index.bzl: in /private/var/tmp/_bazel_x/41ad1bbbf8ac7656dcafc83d22406997/external/npm_angular_bazel/src/ng_package/ng_package.bzl: Label '@build_bazel_rules_nodejs//internal/rollup/rollup_bundle.bzl:rollup_bundle.bzl' crosses boundary of package '@build_bazel_rules_nodejs//internal/rollup' (perhaps you meant to put the colon here: '@build_bazel_rules_nodejs//internal/rollup:rollup_bundle.bzl/rollup_bundle.bzl'?)

this PR fixed this error

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@alexeagle alexeagle alexeagle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@meteorcloudy @LinboLen @alexeagle @googlebot