build(docs-infra): update to latest CLI beta by filipesilva · Pull Request #29764 · angular/angular

filipesilva · 2019-04-08T10:27:38Z

Notable feature include:

Web Worker support (Web Worker support angular-cli#13700)
Seamless NGCC support (feat(@ngtools/webpack): add NGCC as part of the workflow angular-cli#13968)
Sass (dart-sass) support (feat(@angular-devkit/build-angular): use sass instead of node-sass angular-cli#13950)

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

filipesilva · 2019-04-08T10:32:03Z

This PR as is currently errors out:

kamik@RED-X1C6 MINGW64 /d/work/angular/aio (cli-webworker)
$ yarn ~~build
yarn run v1.12.3
$ ng build --configuration=stable
Cannot read property 'endsWith' of undefined
TypeError: Cannot read property 'endsWith' of undefined
    at NgBuildAnalyticsPlugin._collectBundleStats (D:\work\angular\aio\node_modules\@angular-devkit\build-angular\plugins\webpack\analytics.js:174:32)
    at NgBuildAnalyticsPlugin._done (D:\work\angular\aio\node_modules\@angular-devkit\build-angular\plugins\webpack\analytics.js:211:14)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (D:\work\angular\aio\node_modules\tapable\lib\HookCodeFactory.js:32:10), <anonymous>:18:1)
    at AsyncSeriesHook.lazyCompileHook (D:\work\angular\aio\node_modules\tapable\lib\Hook.js:154:20)
    at onCompiled (D:\work\angular\aio\node_modules\webpack\lib\Compiler.js:234:21)
    at hooks.afterCompile.callAsync.err (D:\work\angular\aio\node_modules\webpack\lib\Compiler.js:630:14)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (D:\work\angular\aio\node_modules\tapable\lib\HookCodeFactory.js:32:10), <anonymous>:6:1)
    at AsyncSeriesHook.lazyCompileHook (D:\work\angular\aio\node_modules\tapable\lib\Hook.js:154:20)
    at compilation.seal.err (D:\work\angular\aio\node_modules\webpack\lib\Compiler.js:627:30)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (D:\work\angular\aio\node_modules\tapable\lib\HookCodeFactory.js:32:10), <anonymous>:21:1)
    at AsyncSeriesHook.lazyCompileHook (D:\work\angular\aio\node_modules\tapable\lib\Hook.js:154:20)
    at hooks.optimizeAssets.callAsync.err (D:\work\angular\aio\node_modules\webpack\lib\Compilation.js:1325:35)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (D:\work\angular\aio\node_modules\tapable\lib\HookCodeFactory.js:32:10), <anonymous>:10:1)
    at AsyncSeriesHook.lazyCompileHook (D:\work\angular\aio\node_modules\tapable\lib\Hook.js:154:20)
    at hooks.optimizeChunkAssets.callAsync.err (D:\work\angular\aio\node_modules\webpack\lib\Compilation.js:1316:32)
    at _err2 (eval at create (D:\work\angular\aio\node_modules\tapable\lib\HookCodeFactory.js:32:10), <anonymous>:37:1)

This will be fixed by angular/angular-cli#14104. Until then, for local development, the code changes in that PR can be added to node_modules\@angular-devkit\build-angular\plugins\webpack\analytics.js.

Then the build errors with:

kamik@RED-X1C6 MINGW64 /d/work/angular/aio (cli-webworker)
$ yarn ~~build
yarn run v1.12.3
$ ng build --configuration=stable

Date: 2019-04-08T10:16:22.066Z
Hash: 9b6dd3de5688c7463f48
Time: 9358ms
chunk {0} runtime.741402d1d47331ce975c.js, runtime.741402d1d47331ce975c.js.map (runtime) 1.46 kB [entry] [rendered]
chunk {1} main.4af9b61479361f268d39.js, main.4af9b61479361f268d39.js.map (main) 182 bytes [initial] [rendered]
chunk {2} polyfills.961ffc045f11208a7197.js, polyfills.961ffc045f11208a7197.js.map (polyfills) 189 bytes [initial] [rendered]
chunk {3}  (styles) [initial] [rendered]

ERROR in ./src/styles.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/lib/loader.js):

undefined
   ^
      Parent "table tbody > tr >" is incompatible with this selector.
   ╷
73 │     &:last-child td {
   │     ^^^^^^^^^^^^^^^^
   ╵
  src\styles\2-modules\_table.scss 73:5         @import
  src\styles\2-modules\_modules-dir.scss 23:12  @import
  src\styles\main.scss 14:9                     @import
  stdin 3:9                                     root stylesheet
      in D:\work\angular\aio\src\styles\2-modules\_table.scss (line 73, column 5)
    at runLoaders (D:\work\angular\aio\node_modules\webpack\lib\NormalModule.js:301:20)
    at D:\work\angular\aio\node_modules\loader-runner\lib\LoaderRunner.js:367:11
    at D:\work\angular\aio\node_modules\loader-runner\lib\LoaderRunner.js:233:18
    at context.callback (D:\work\angular\aio\node_modules\loader-runner\lib\LoaderRunner.js:111:13)
    at render (D:\work\angular\aio\node_modules\sass-loader\lib\loader.js:52:13)
    at Function.$2 (D:\work\angular\aio\node_modules\sass\sass.dart.js:24366:48)
    at wN.$2 (D:\work\angular\aio\node_modules\sass\sass.dart.js:15294:15)
    at uS.vr (D:\work\angular\aio\node_modules\sass\sass.dart.js:9034:42)
    at uS.vq (D:\work\angular\aio\node_modules\sass\sass.dart.js:9036:32)
    at iy.uD (D:\work\angular\aio\node_modules\sass\sass.dart.js:8384:46)
    at ur.$0 (D:\work\angular\aio\node_modules\sass\sass.dart.js:8526:7)
    at Object.eG (D:\work\angular\aio\node_modules\sass\sass.dart.js:1512:80)
    at ad.ba (D:\work\angular\aio\node_modules\sass\sass.dart.js:8447:3)
    at iM.ba (D:\work\angular\aio\node_modules\sass\sass.dart.js:8377:25)
    at iM.cv (D:\work\angular\aio\node_modules\sass\sass.dart.js:8364:6)
    at px.cv (D:\work\angular\aio\node_modules\sass\sass.dart.js:8154:35)
ERROR in src/app/search/search-worker.ts(76,5): error TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'PageInfo' has no compatible call signatures.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

There are two errors here:

A sass error, where dart-sass behaviour differs from the old node-sass (more info at https://github.com/sass/dart-sass#behavioral-differences-from-ruby-sass). The old node-sass processor can be set by following the instructions in feat(@angular-devkit/build-angular): use sass instead of node-sass angular-cli#13950, but it would be better to adhere to dart-sass instead since it is stricter.
A TS typings error in search-worker.ts, which is still in the process of being converted to TS.

filipesilva · 2019-04-08T10:36:06Z

@clydin can you provide guidance on how to enable analytics for AIO locally and in CI?

gkalpak · 2019-04-09T08:49:21Z

@filipesilva: FYI, I've fixed the Scss issues in #28530 (if you want to copy it over): b4f65da90

googlebot · 2019-04-09T14:20:53Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

mary-poppins · 2019-04-09T14:26:14Z

You can preview ea88d8c at https://pr29764-ea88d8c.ngbuilds.io/.

mary-poppins · 2019-04-12T13:34:54Z

You can preview 1e243ad at https://pr29764-1e243ad.ngbuilds.io/.

googlebot · 2019-04-15T09:16:01Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

mary-poppins · 2019-04-15T09:24:12Z

You can preview 179fa4c at https://pr29764-179fa4c.ngbuilds.io/.

mary-poppins · 2019-04-15T10:24:14Z

You can preview 6907a47 at https://pr29764-6907a47.ngbuilds.io/.

mary-poppins · 2019-04-15T12:35:18Z

You can preview 6f995e4 at https://pr29764-6f995e4.ngbuilds.io/.

mary-poppins · 2019-04-15T12:58:19Z

You can preview 8312d65 at https://pr29764-8312d65.ngbuilds.io/.

filipesilva · 2019-04-15T13:36:48Z

Note: both @petebacondarwin and @gkalpak worked on this PR, but at some point I had to git reset and remake the commits so their contributions were lost in mine.

mary-poppins · 2019-04-15T13:47:45Z

You can preview 526b9e7 at https://pr29764-526b9e7.ngbuilds.io/.

gkalpak

🎉

gkalpak · 2019-04-15T14:04:25Z

OOC, what does this comment refer to? What definitions? Remove from where?

This comment shouldn't be here anymore. It referred to things in the old JS version:

/* global importScripts, lunr */ // NOTE: This needs to be kept in sync with `ngsw-config.json`. importScripts('/generated/lunr.min.js');

Will track those down and remove them.

Huh, it's a native function that's present in workers: https://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope/importScripts. Didn't know that. Will just remove the comment then.

mary-poppins · 2019-04-15T14:18:43Z

You can preview e229221 at https://pr29764-e229221.ngbuilds.io/.

mary-poppins · 2019-04-15T17:25:17Z

You can preview 009c901 at https://pr29764-009c901.ngbuilds.io/.

PR Close #29764

PR Close angular#29764

…29764) PR Close angular#29764

angular-automatic-lock-bot · 2019-09-14T23:22:29Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Apr 8, 2019

filipesilva requested a review from petebacondarwin April 8, 2019 10:41

googlebot added cla: no and removed cla: yes labels Apr 9, 2019

googlebot added cla: yes and removed cla: no labels Apr 15, 2019

filipesilva marked this pull request as ready for review April 15, 2019 13:38

filipesilva requested a review from a team April 15, 2019 13:38

filipesilva added the target: major This PR is targeted for the next major release label Apr 15, 2019

gkalpak approved these changes Apr 15, 2019

View reviewed changes

gkalpak reviewed Apr 15, 2019

View reviewed changes

gkalpak added area: build & ci Related the build and CI infrastructure of the project comp: docs-infra action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 15, 2019

ngbot Bot added this to the needsTriage milestone Apr 15, 2019

gkalpak added PR target: TBD and removed target: major This PR is targeted for the next major release labels Apr 15, 2019

filipesilva removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 15, 2019

filipesilva removed the request for review from petebacondarwin April 15, 2019 14:23

filipesilva added target: major This PR is targeted for the next major release and removed PR target: TBD labels Apr 15, 2019

gkalpak added the action: merge The PR is ready for merge by the caretaker label Apr 15, 2019

gkalpak mentioned this pull request Apr 15, 2019

build(docs-infra): update to latest CLI beta #29908

Closed

filipesilva added 2 commits April 15, 2019 20:19

build(docs-infra): update to CLI 8 beta.13

b72271b

build(docs-infra): convert search-worker.js to TypeScript

009c901

alxhub closed this in ee603a3 Apr 15, 2019

alxhub pushed a commit that referenced this pull request Apr 15, 2019

build(docs-infra): convert search-worker.js to TypeScript (#29764)

3a836c3

PR Close #29764

filipesilva deleted the cli-webworker branch April 15, 2019 18:17

wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019

build(docs-infra): update to CLI 8 beta.13 (angular#29764)

e9ec93d

PR Close angular#29764

wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019

build(docs-infra): convert search-worker.js to TypeScript (angular#…

7afb631

…29764) PR Close angular#29764

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

Conversation

filipesilva commented Apr 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

filipesilva commented Apr 8, 2019

Uh oh!

filipesilva commented Apr 8, 2019

Uh oh!

gkalpak commented Apr 9, 2019

Uh oh!

googlebot commented Apr 9, 2019

Uh oh!

mary-poppins commented Apr 9, 2019

Uh oh!

mary-poppins commented Apr 12, 2019

Uh oh!

googlebot commented Apr 15, 2019

Uh oh!

mary-poppins commented Apr 15, 2019

Uh oh!

mary-poppins commented Apr 15, 2019

Uh oh!

mary-poppins commented Apr 15, 2019

Uh oh!

mary-poppins commented Apr 15, 2019

Uh oh!

filipesilva commented Apr 15, 2019

Uh oh!

mary-poppins commented Apr 15, 2019

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

gkalpak Apr 15, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Apr 15, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Apr 15, 2019

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Apr 15, 2019

Uh oh!

mary-poppins commented Apr 15, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

filipesilva commented Apr 8, 2019 •

edited

Loading