docs(ivy): add /migration/lazy-routes to AIO by alexeagle · Pull Request #29730 · angular/angular

alexeagle · 2019-04-05T17:13:46Z

No description provided.

mary-poppins · 2019-04-05T17:40:30Z

You can preview ea288cf at https://pr29730-ea288cf.ngbuilds.io/.
You can preview 01f483e at https://pr29730-01f483e.ngbuilds.io/.

alexeagle · 2019-04-05T17:44:03Z

note: still discussing in slack #tools-fix-lazy-routes whether we want to have the migration built-in

kara · 2019-04-05T22:34:56Z

+# Updating Angular Lazy Routes
+
+When we first introduced lazy routes, there wasn't browser support for dynamically loading additional JavaScript.
+Angular created our own scheme using the syntax `loadChildren: './lazy/lazy.module#LazyModule'` and built complex tooling to support it.


Can we pull out the old syntax into a code snippet? Otherwise it's hard to find what pattern is necessary to change.

kara · 2019-04-05T22:35:06Z

+1. Why isn't this migration run automatically by `ng update`?
+
+    This migration is optional in Angular 8.
+    Since we expect the majority of users will not opt-into Ivy, we don't want to introduce the risk of breaking your application in case your code or a library you use depends on the current string-based syntax in some way.


Suggested change

Since we expect the majority of users will not opt-into Ivy, we don't want to introduce the risk of breaking your application in case your code or a library you use depends on the current string-based syntax in some way.

Since we expect the majority of users will not opt into Ivy, we don't want to introduce the risk of breaking your application in case your code or a library you use depends on the current string-based syntax in some way.

gkalpak

More work is needed if you want to add a new migration sub-path (e.g. you need more changes to show the SideNav, show a ToC, etc.). But, we should first discuss whether we want to introduce a new sub-path.

petebacondarwin · 2019-04-07T18:38:10Z

@gkalpak - @alexeagle and I discussed the navigation but for now he just wanted to have a URL available.

trotyl · 2019-04-14T12:29:05Z

+
+When we first introduced lazy routes, there wasn't browser support for dynamically loading additional JavaScript.
+Angular created our own scheme using the syntax `loadChildren: './lazy/lazy.module#LazyModule'` and built complex tooling to support it.
+Now that EcmaScript dynamic import is a standard and is supported in many browsers, it's time for Angular applications to use this new syntax.


EcmaScript -> ECMAScript for consistency?

trotyl · 2019-04-14T12:32:20Z

+
+When we first introduced lazy routes, there wasn't browser support for dynamically loading additional JavaScript.
+Angular created our own scheme using the syntax `loadChildren: './lazy/lazy.module#LazyModule'` and built complex tooling to support it.
+Now that EcmaScript dynamic import is a standard and is supported in many browsers, it's time for Angular applications to use this new syntax.


dynamic import is a standard

It is NOT a standard, which got stuck in stage 3 due to security issue. (Need to land Realms first)

trotyl · 2019-04-14T12:36:07Z

+1. Install the migrator:
+
+    ```sh
+    $ npm install @phenomnomnominal/angular-lazy-routes-fix -D


Would it better to use full-form of CLI options? People may forget about what it stands for.

filipesilva · 2019-04-19T08:14:10Z

+Angular created our own scheme using the syntax `loadChildren: './lazy/lazy.module#LazyModule'` and built complex tooling to support it.
+Now that EcmaScript dynamic import is a standard and is supported in many browsers, it's time for Angular applications to use this new syntax.
+
+> Updating your lazy routes to dynamic import is *required* in order to use Angular Ivy.


At the moment it is not required anymore, just highly recommended.

This would be where to put the new text from #29955:

The string syntax for the loadChildren route specification is deprecated in Angular version 8, in favor of new syntax that uses an import statement.
As part of updating an application to Angular version 8, it is recommended that you update to the new import syntax.
You can use angular-lazy-routes-fix to perform the transformation automatically.

For example:

const routes: Routes = [{ path: 'lazy', // The string syntax for loadChildren is deprecated: // loadChildren: './lazy/lazy.module#LazyModule' // This has been transformed to use the new import syntax. loadChildren: () => import('./lazy/lazy.module').then(m => m.LazyModule) }];

Ivy supports both the deprecated string syntax and the recommended import syntax.
If you have updated your lazy routes to use the import() statement but are not using Ivy,
make sure your default build options in angular.json include the flag "experimentalImportFactories": true.

filipesilva · 2019-04-19T08:20:06Z

+
+1. Why isn't this migration run automatically by `ng update`?
+
+    This migration is optional in Angular 8.


angular/angular-cli#14181 doesn't seem to be optional currently.

angular-automatic-lock-bot · 2019-09-15T00:22:09Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alexeagle requested a review from IgorMinar as a code owner April 5, 2019 17:13

googlebot added the cla: yes label Apr 5, 2019

docs(ivy): add /migration/lazy-routes to AIO

01f483e

alexeagle force-pushed the fix-lazy-routes branch from ea288cf to 01f483e Compare April 5, 2019 17:30

alexeagle requested a review from a team April 5, 2019 17:30

alexeagle added the aio: preview label Apr 5, 2019

alexeagle added the state: blocked label Apr 5, 2019

kara reviewed Apr 5, 2019

View reviewed changes

gkalpak reviewed Apr 7, 2019

View reviewed changes

trotyl reviewed Apr 14, 2019

View reviewed changes

benlesh added the comp: docs label Apr 17, 2019

ngbot Bot added this to the needsTriage milestone Apr 17, 2019

filipesilva reviewed Apr 19, 2019

View reviewed changes

filipesilva mentioned this pull request Apr 19, 2019

Update Ivy opt-in doc #29955

Closed

3 of 14 tasks

alexeagle closed this Apr 24, 2019

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019

	Since we expect the majority of users will not opt-into Ivy, we don't want to introduce the risk of breaking your application in case your code or a library you use depends on the current string-based syntax in some way.
	Since we expect the majority of users will not opt into Ivy, we don't want to introduce the risk of breaking your application in case your code or a library you use depends on the current string-based syntax in some way.


		1. Why isn't this migration run automatically by `ng update`?

		This migration is optional in Angular 8.

Conversation

alexeagle commented Apr 5, 2019

Uh oh!

mary-poppins commented Apr 5, 2019

Uh oh!

alexeagle commented Apr 5, 2019

Uh oh!

kara Apr 5, 2019

Choose a reason for hiding this comment

Uh oh!

kara Apr 5, 2019

Choose a reason for hiding this comment

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin commented Apr 7, 2019

Uh oh!

trotyl Apr 14, 2019

Choose a reason for hiding this comment

Uh oh!

trotyl Apr 14, 2019

Choose a reason for hiding this comment

Uh oh!

trotyl Apr 14, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Apr 19, 2019

Choose a reason for hiding this comment

Uh oh!

jbogarthyde Apr 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

filipesilva Apr 19, 2019

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 15, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

jbogarthyde Apr 19, 2019 •

edited

Loading