Skip to content

docs: add Web Worker guide - #29633

Closed
filipesilva wants to merge 1 commit into
angular:masterfrom
filipesilva:web-worker-doc
Closed

docs: add Web Worker guide#29633
filipesilva wants to merge 1 commit into
angular:masterfrom
filipesilva:web-worker-doc

Conversation

@filipesilva

@filipesilva filipesilva commented Apr 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Followup to angular/angular-cli#13700

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@filipesilva
filipesilva requested a review from jenniferfell April 1, 2019 14:45
@filipesilva
filipesilva requested a review from IgorMinar as a code owner April 1, 2019 14:45
@filipesilva
filipesilva requested a review from a team April 1, 2019 14:45
@filipesilva filipesilva mentioned this pull request Apr 1, 2019
Merged
11 tasks done
@mary-poppins

mary-poppins commented Apr 1, 2019

Copy link
Copy Markdown

You can preview a163b21 at https://pr29633-a163b21.ngbuilds.io/.

@filipesilva filipesilva added the target: major This PR is targeted for the next major release label Apr 1, 2019
@mary-poppins

mary-poppins commented Apr 1, 2019

Copy link
Copy Markdown

You can preview 2f09d20 at https://pr29633-2f09d20.ngbuilds.io/.

gkalpak
gkalpak approved these changes Apr 1, 2019
View reviewed changes
Comment thread .github/CODEOWNERS Outdated

@gkalpak gkalpak Apr 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Comment thread aio/content/guide/web-worker.md Outdated

@gkalpak gkalpak Apr 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean src/app/app.component.ts?

@filipesilva filipesilva Apr 1, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, yes. Thank you.

Comment thread aio/content/guide/web-worker.md Outdated

@gkalpak gkalpak Apr 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fallback to mechanism to perform --> fallback mechanism to perform

@filipesilva filipesilva Apr 1, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gkalpak gkalpak added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 1, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Apr 1, 2019
@mary-poppins

mary-poppins commented Apr 1, 2019

Copy link
Copy Markdown

You can preview 63a622d at https://pr29633-63a622d.ngbuilds.io/.

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 1, 2019
@filipesilva

filipesilva commented Apr 1, 2019

Copy link
Copy Markdown
Contributor Author

caretaker: I believe the current reviews should be all that are needed for this PR.

@gkalpak

gkalpak commented Apr 1, 2019

Copy link
Copy Markdown
Member

caretaker: I believe the current reviews should be all that are needed for this PR.

Only if @alexeagle chooses to use his global approval super-power (which he must explicitly state with a comment on the PR) 😁

@jasonaden

jasonaden commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

I'm going to take the action of labeling this merge from @alexeagle to mean he wants it merged.

@jasonaden jasonaden closed this in 8bfaaf1 Apr 1, 2019
@filipesilva
filipesilva deleted the web-worker-doc branch April 2, 2019 08:17
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@filipesilva @wKoza
docs: add Web Worker guide (angular#29633)
b9b37e0 
Followup to angular/angular-cli#13700

PR Close angular#29633
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jenniferfell jenniferfell Awaiting requested review from jenniferfell
@IgorMinar IgorMinar Awaiting requested review from IgorMinar
2 more reviewers
@alexeagle alexeagle alexeagle approved these changes
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

6 participants

@filipesilva @mary-poppins @gkalpak @jasonaden @alexeagle @googlebot