Skip to content

docs: copy-edit ivy opt-in page - #29507

Closed
jbogarthyde wants to merge 1 commit into
angular:masterfrom
jbogarthyde:jb-ivy-edit
Closed

docs: copy-edit ivy opt-in page#29507
jbogarthyde wants to merge 1 commit into
angular:masterfrom
jbogarthyde:jb-ivy-edit

Conversation

@jbogarthyde

@jbogarthyde jbogarthyde commented Mar 25, 2019

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jbogarthyde jbogarthyde added comp: docs effort1: hours target: major This PR is targeted for the next major release labels Mar 25, 2019
@jbogarthyde
jbogarthyde requested a review from a team March 25, 2019 16:50
@ngbot ngbot Bot modified the milestone: needsTriage Mar 25, 2019
@mary-poppins

mary-poppins commented Mar 25, 2019

Copy link
Copy Markdown

You can preview 4f90c27 at https://pr29507-4f90c27.ngbuilds.io/.

filipesilva
filipesilva approved these changes Mar 26, 2019
View reviewed changes

@filipesilva filipesilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbogarthyde worth mentioning that we're still finishing up what this document will contain. #29506 is being drafted at the moment.

Do you want to get this one in for now and then review that one? Or would you prefer the other way around?

@jbogarthyde

jbogarthyde commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

I've modified this to apply the edits to the current text of #29506, including Alan's comments.

@mary-poppins

mary-poppins commented Mar 26, 2019

Copy link
Copy Markdown

You can preview e6a9691 at https://pr29507-e6a9691.ngbuilds.io/.

@filipesilva

filipesilva commented Mar 26, 2019

Copy link
Copy Markdown
Contributor

@jbogarthyde the changes in #29506 are still being drafted and can't go in yet. They are blocked on a couple of feature PRs in Angular CLI which might still take about a week to get released.

@mary-poppins

mary-poppins commented Mar 26, 2019

Copy link
Copy Markdown

You can preview 8a51f17 at https://pr29507-8a51f17.ngbuilds.io/.

@mary-poppins

mary-poppins commented Mar 26, 2019

Copy link
Copy Markdown

You can preview 2aa1abb at https://pr29507-2aa1abb.ngbuilds.io/.

@mary-poppins

mary-poppins commented Mar 26, 2019

Copy link
Copy Markdown

You can preview 17eb91f at https://pr29507-17eb91f.ngbuilds.io/.

@mary-poppins

mary-poppins commented Mar 27, 2019

Copy link
Copy Markdown

You can preview c745e3d at https://pr29507-c745e3d.ngbuilds.io/.

@mary-poppins

mary-poppins commented Mar 28, 2019

Copy link
Copy Markdown

You can preview 50afe5c at https://pr29507-50afe5c.ngbuilds.io/.

@jbogarthyde jbogarthyde added the action: merge The PR is ready for merge by the caretaker label Mar 28, 2019
@jasonaden jasonaden closed this in 6c76dfc Mar 28, 2019
@jbogarthyde
jbogarthyde deleted the jb-ivy-edit branch April 1, 2019 15:50
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@jbogarthyde @wKoza
docs: copy-edit ivy opt-in page (angular#29507)
c236dbe 
PR Close angular#29507
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@filipesilva filipesilva filipesilva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@jbogarthyde @mary-poppins @filipesilva @googlebot