Repository navigation
Ivy guide update - #29506
Ivy guide update#29506filipesilva wants to merge 2 commits into
Conversation
|
You can preview 8ced065 at https://pr29506-8ced065.ngbuilds.io/. |
There was a problem hiding this comment.
for version 8, this tsconfig is not under src anymore. it's in the root.
tsconfig.app.json
There was a problem hiding this comment.
src/tsconfig.app.json -> tsconfig.app.json
There was a problem hiding this comment.
say where are the default build options? (which file)
There was a problem hiding this comment.
Don't you still need to restore node_modules/ to clean up typings modified by ngcc?
There was a problem hiding this comment.
AFAIK it's ok to leave it there for VE compilations because the typings were additive. So if you want to switch back and forth there is no need to reinstall. Also if you want to switch, and you reinstall, the first build will again take longer.
Is there any real risk that new typings will be used by accident?
There was a problem hiding this comment.
Well, even if additive, the typings will be wrong. (For example, certain classes will claim thay have some properties that they don't.)
I don't know of any reason for people to want to use or care about those properties, so they are probably harmless, but I might miss something.
|
You can preview ac5bc0f at https://pr29506-ac5bc0f.ngbuilds.io/. |
filipesilva
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Ivy guide is updated with up to date steps.
Does this PR introduce a breaking change?
Other information
Blocked on angular/angular-cli#13948 and angular/angular-cli#13968