Skip to content

ci: do not cache modified "node_modules" in "material-unit-tests" job #29416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devversion wants to merge 1 commit into from
Closed

ci: do not cache modified "node_modules" in "material-unit-tests" job #29416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,16 +581,22 @@ jobs:
command: ./scripts/ci/clone_angular_material_repo.sh
- restore_cache:
keys:
- v1-angular-material-{{ checksum "material_repo_sha" }}
- v1-angular-material-
- v2-angular-material-{{ checksum "material_repo_sha" }}
Comment thread
devversion marked this conversation as resolved.
Resolved
- v2-angular-material-
- run:
name: "Running Material unit tests"
command: ./scripts/ci/run_angular_material_unit_tests.sh
name: Installing Material dependencies.
command: yarn --cwd ${MATERIAL_REPO_TMP_DIR} install --frozen-lockfile --non-interactive
# Save the cache before we run the Material unit tests script. This is necessary
# because we don't want to cache the node modules which have been modified to contain
# the attached Ivy package output.
- save_cache:
key: v1-angular-material-{{ checksum "material_repo_sha" }}
key: v2-angular-material-{{ checksum "material_repo_sha" }}
paths:
# Needs to be hardcoded because environment variables are not interpolated here.
- "/tmp/material2/node_modules"
- run:
name: "Running Material unit tests"
command: ./scripts/ci/run_angular_material_unit_tests.sh

workflows:
version: 2
Expand Down
3 changes: 0 additions & 3 deletions scripts/ci/run_angular_material_unit_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ angular_dir=$(pwd)
# Switch into Material directory.
cd ${MATERIAL_REPO_TMP_DIR}

# Install dependencies for the freshly cloned repo.
yarn install --frozen-lockfile --non-interactive

# Install this version of Angular into the freshly cloned repo.
rm -rf ./node_modules/@angular/*
cp -r ${angular_dir}/dist/packages-dist-ivy-aot/* ./node_modules/@angular/
Expand Down