Skip to content

docs: fix typo (culd -> could) - #29412

Closed
meriturva wants to merge 1 commit into
angular:masterfrom
meriturva:patch-1
Closed

meriturva wants to merge 1 commit into
angular:masterfrom
meriturva:patch-1

Conversation

@meriturva

Copy link
Copy Markdown

Just fix a typo error!

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@meriturva
meriturva requested a review from a team March 20, 2019 07:09
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@meriturva

Copy link
Copy Markdown
Author

I signed it!

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thx 👍
Could you please change the commit message to something like:

docs: fix typo (culd -> could)

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: docs target: patch This PR is targeted for the next patch release labels Mar 20, 2019
@ngbot ngbot Bot modified the milestone: needsTriage Mar 20, 2019
@gkalpak gkalpak changed the title docs(changelog): typo error (culd -> could) docs: fix typo (culd -> could) Mar 20, 2019
@meriturva

Copy link
Copy Markdown
Author

@gkalpak Changed, could you please check it now?

@gkalpak

gkalpak commented Mar 20, 2019

Copy link
Copy Markdown
Member

@meriturva, you seem to have added a new commit with the correct message (but leaving the original commit too) and a "merge" commit. You need to squash all three commits into one (and set the correct commit message). See here for instructions.

@meriturva

Copy link
Copy Markdown
Author

@gkalpak done. (sorry amend was not enough)

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 20, 2019
@ngbot

ngbot Bot commented Mar 20, 2019

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: material-unit-tests" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@gkalpak

gkalpak commented Mar 20, 2019 •

Copy link
Copy Markdown
Member

merge-assistance: The material-unit-tests failure is unrelated to this PR.

(@meriturva, the fix for material-unit-tests has just been merged into master (#29416), so you can also rebase on master to make CI green, if you feel like it 😉)

@matsko matsko added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 20, 2019
@matsko matsko closed this in 1a4d4a0 Mar 20, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants