Skip to content

docs: update ivy opt-in flag - #29010

Closed
filipesilva wants to merge 1 commit into
angular:masterfrom
filipesilva:ivy-doc-flag
Closed

filipesilva wants to merge 1 commit into
angular:masterfrom
filipesilva:ivy-doc-flag

Conversation

@filipesilva

@filipesilva filipesilva commented Feb 27, 2019 •

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

Followup to #28569 (comment) and angular/angular-cli#13773.

Note: this flag will only work on @angular/cli@8.0.0-beta.3 (currently unreleased) and above.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@filipesilva filipesilva added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 27, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Feb 27, 2019
@mary-poppins

Copy link
Copy Markdown

You can preview 0c98cdd at https://pr29010-0c98cdd.ngbuilds.io/.

@filipesilva

filipesilva commented Feb 27, 2019 •

Copy link
Copy Markdown
Contributor Author

This file gets matched for Igor only as a reviewer. According to the codeowners file this is a bug:

# ================================================
#  Default Owners
# (in case no pattern matches a path in a PR - this should be treated as a bug and result in adding the path to CODEOWNERS)
# ================================================

* @IgorMinar @angular/framework-global-approvers

It looks like each guide is currently assigned to specific groups. So I guess this guide should also be assigned to some specific group. @IgorMinar I was told you set up this list yourself. Who should be the codeowner for this guide?

@gkalpak

gkalpak commented Feb 27, 2019

Copy link
Copy Markdown
Member

BTW, I have a PR updating CODEOWNERS with missing guides etc: #28597
Happy to update that (according to @IgorMinar's response 😉).

@gkalpak

gkalpak commented Feb 28, 2019

Copy link
Copy Markdown
Member

FYI, I've added ivy.md to the "Framework/cli integration" CODEOWNERS section (which is owned by the tools-cli group) in #28597#diff-5cfb934ca.

Followup to #28569 (comment) and angular/angular-cli#13773.

Note: this flag will only work on `@angular/cli@8.0.0-beta.3` (currently unreleased) and above.
@filipesilva

Copy link
Copy Markdown
Contributor Author

@gkalpak thanks, I rebased now and it should request a review from that group.

@filipesilva
filipesilva requested a review from hansl March 6, 2019 11:08
@filipesilva

Copy link
Copy Markdown
Contributor Author

Hm, no.... it didn't reset the needed reviews... :/

@mary-poppins

Copy link
Copy Markdown

You can preview eaeb179 at https://pr29010-eaeb179.ngbuilds.io/.

@alexeagle alexeagle added target: major This PR is targeted for the next major release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 6, 2019
@ngbot ngbot Bot added the action: merge The PR is ready for merge by the caretaker label Mar 6, 2019
@alexeagle

Copy link
Copy Markdown
Contributor

Caretaker assist: this is just a trivial correction to a CLI flag, doesn't need the listed reviews (and we are having problems with Codeowners on this one)

@gkalpak

gkalpak commented Mar 6, 2019

Copy link
Copy Markdown
Member

@gkalpak thanks, I rebased now and it should request a review from that group.

@filipesilva, the PR is not merged yet, so the changes will not take effect until it is 😁

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants