feat(core): update schematic to migrate to explicit query timing by devversion · Pull Request #28983 · angular/angular

devversion · 2019-02-26T17:54:26Z

Introduces an update schematic for the @angular/core package that
automatically migrates pre-V8 ViewChild and ContentChild queries to
the new explicit timing syntax. This is not required yet, but with Ivy, queries
will be "dynamic" by default. Therefore specifying an explicit query timing
ensures that developers can smoothly migrate to Ivy (once it's the default).

Read more about the explicit timing API here: #28810

kara

Thanks so much for doing this! A few thoughts below.

JoostK

Awesome work! 🎉

devversion · 2019-02-27T19:32:05Z

@kara @JoostK I've addressed the feedback. thank you!

kara

LGTM for behavior. @alexeagle should probably look at bazel sections.

Note: Looks like linter is upset

alexeagle

no issues from Bazel

AndrewKushnir · 2019-03-04T19:54:18Z

Presubmit

alexeagle

caretaker: I was able to get this green in g3 by

fixing the type-check error mentioned in a comment here
adding a new file third_party/javascript/angular2/rc/packages/core/schematics/BUILD containing

load("//javascript/typescript:build_defs.bzl", "ts_library")

licenses(["notice"])  # MIT License

ts_library(
    name = "schematics",
    srcs = glob(["migrations/**/*.ts"], exclude = [
        "migrations/static-queries/*.ts",
        "**/*_spec.ts",
    ]),
    deps = [
         "//third_party/javascript/node_modules/typescript:es2015.core",
         "//third_party/javascript/node_modules/typescript:typings",
    ]
)

note that this also has to be treated specially in copybara since this file would be g3-only.

The fundamental problem is that we don't share the BUILD files between github and g3. Would be an interesting project.

Introduces an update schematic for the "@angular/core" package that automatically migrates pre-V8 "ViewChild" and "ContentChild" queries to the new explicit timing syntax. This is not required yet, but with Ivy, queries will be "dynamic" by default. Therefore specifying an explicit query timing ensures that developers can smoothly migrate to Ivy (once it's the default). Read more about the explicit timing API here: angular#28810

Properly handle chained class inheritances

Detect input setters with static query usage

Fix no implicit returns G3 error. Move specs into packages/core/schematis/test/* folder

alexeagle · 2019-03-05T19:51:52Z

Mailed cl/236891637 to @AndrewKushnir so that the new schematics/ directory here won't be compiled in g3 yet

AndrewKushnir · 2019-03-05T20:11:01Z

Presubmit #2

AndrewKushnir · 2019-03-05T20:21:08Z

@alexeagle it looks like Presubmit and Guitar tests are still failing. Could you please help look into this?

AndrewKushnir · 2019-03-05T21:38:06Z

Presubmit #3 (after additional changes in g3)

AndrewKushnir · 2019-03-05T22:22:19Z

Presubmit was successful, I've merged this PR. Thanks everyone for the help!

angular-automatic-lock-bot · 2019-09-14T19:21:42Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

devversion self-assigned this Feb 26, 2019

googlebot added the cla: yes label Feb 26, 2019

devversion force-pushed the feat/schematics-core-static-query branch 2 times, most recently from a7f19f2 to 75ee651 Compare February 26, 2019 18:37

devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: core Issues related to the framework runtime labels Feb 26, 2019

ngbot Bot added this to the needsTriage milestone Feb 26, 2019

devversion marked this pull request as ready for review February 26, 2019 18:38

devversion requested a review from a team February 26, 2019 18:38

devversion removed their assignment Feb 26, 2019

devversion requested review from alexeagle and jelbourn February 26, 2019 18:38

kara suggested changes Feb 26, 2019

View reviewed changes

Comment thread packages/core/schematics/migrations/static-queries/index_spec.ts Resolved

Comment thread packages/core/schematics/migrations/static-queries/index_spec.ts Resolved

JoostK reviewed Feb 26, 2019

View reviewed changes

devversion force-pushed the feat/schematics-core-static-query branch from 0675789 to ad707f9 Compare February 27, 2019 19:30

jelbourn reviewed Feb 27, 2019

View reviewed changes

Comment thread packages/core/schematics/utils/project_tsconfig_paths.ts Resolved

kara reviewed Feb 27, 2019

View reviewed changes

Comment thread packages/core/schematics/migrations/static-queries/angular/analyze_query_usage.ts Resolved

devversion added state: WIP and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 27, 2019

devversion force-pushed the feat/schematics-core-static-query branch from b916b33 to 604b587 Compare March 1, 2019 00:26

devversion added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Mar 1, 2019

kara approved these changes Mar 1, 2019

View reviewed changes

devversion force-pushed the feat/schematics-core-static-query branch from 604b587 to ad88378 Compare March 1, 2019 17:39

alexeagle approved these changes Mar 4, 2019

View reviewed changes

alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 4, 2019

AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Mar 4, 2019

AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit labels Mar 4, 2019

alexeagle reviewed Mar 4, 2019

View reviewed changes

Comment thread packages/core/schematics/migrations/static-queries/angular/analyze_query_usage.ts Resolved

Comment thread packages/core/schematics/utils/project_tsconfig_paths_spec.ts Resolved

devversion added 4 commits March 5, 2019 18:25

fixup! feat(core): update schematic to migrate to explicit query timing

f18d356

Properly handle chained class inheritances

fixup! feat(core): update schematic to migrate to explicit query timing

daed4c7

Detect input setters with static query usage

fixup! feat(core): update schematic to migrate to explicit query timing

b2e2580

Fix no implicit returns G3 error. Move specs into packages/core/schematis/test/* folder

devversion force-pushed the feat/schematics-core-static-query branch from ad88378 to b2e2580 Compare March 5, 2019 17:35

devversion added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 5, 2019

kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 5, 2019

AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 5, 2019

AndrewKushnir closed this in 6215799 Mar 5, 2019

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

Conversation

devversion commented Feb 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kara left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoostK left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devversion commented Feb 27, 2019

Uh oh!

Uh oh!

Uh oh!

kara left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexeagle left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir commented Mar 4, 2019

Uh oh!

alexeagle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alexeagle commented Mar 5, 2019

Uh oh!

AndrewKushnir commented Mar 5, 2019

Uh oh!

AndrewKushnir commented Mar 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewKushnir commented Mar 5, 2019

Uh oh!

AndrewKushnir commented Mar 5, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

devversion commented Feb 26, 2019 •

edited

Loading

kara left a comment •

edited

Loading

kara left a comment •

edited

Loading

AndrewKushnir commented Mar 5, 2019 •

edited

Loading