Update to rules_typescript 0.25.1 (PATCH-ONLY)#28896
Closed
gregmagolan wants to merge 3 commits into
Closed
Conversation
gregmagolan
changed the title
gregmagolan
added
the
area: bazel
alexeagle
approved these changes
Feb 21, 2019
IgorMinar
approved these changes
Feb 22, 2019
Contributor
|
sigh... lots of conflicts.. can you please rebase? I'm sorry |
Contributor
Author
All good. I think it conflicted with one of my PRs anyway. I'll rebase. |
* build_bazel_rules_typescript renamed to npm_bazel_typescript * build_bazel_rules_karma renamed to npm_bazel_karma * browser_repositories.bzl removed and now using @npm_bazel_karma//:browser_repositories.bzl * includes some fixes for future ts_library devmode es2015 support but some failure still remain when devmode is es2015 so this PR keeps it as es5 using the bazelOptions.devmodeTargetOverride tsconfig setting
…_repositories.bzl in bazel schematics
gregmagolan
added
the
merge: caretaker note
benlesh
pushed a commit
that referenced
this pull request
Feb 22, 2019
* build_bazel_rules_typescript renamed to npm_bazel_typescript * build_bazel_rules_karma renamed to npm_bazel_karma * browser_repositories.bzl removed and now using @npm_bazel_karma//:browser_repositories.bzl * includes some fixes for future ts_library devmode es2015 support but some failure still remain when devmode is es2015 so this PR keeps it as es5 using the bazelOptions.devmodeTargetOverride tsconfig setting PR Close #28896
Contributor
|
This is merged as of b686449 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch version of #28625