Repository navigation
Conversation
kara
added
action: review
mhevery
approved these changes
Feb 19, 2019
kara
added
action: cleanup
We previously disabled this test because we did not yet have static query support in Ivy and the planned API would be slightly different. Now that a static query flag is available that works in both View Engine and Ivy, the test has been updated to use that flag and has been turned on to run in CI. Since the test was always unrelated to queries and was intended to test *ngIf behavior, updating the test in this instance seems reasonable.
kara
added
merge: caretaker note
Contributor
Author
|
merge-assistance: global approval to turn on this test. (@IgorMinar feel free to review though!) |
IgorMinar
approved these changes
Feb 20, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously disabled this test because we did not yet have
static query support in Ivy and the planned API would be
slightly different. Now that a static query flag is available
that works in both View Engine and Ivy, the test has been
updated to use that flag and has been turned on to run in CI.
Since the test was always unrelated to queries and was intended
to test *ngIf behavior, updating the test in this instance
seems reasonable.