Backport of #28055 commits - #28736
Closed
petebacondarwin wants to merge 3 commits into
Closed
petebacondarwin wants to merge 3 commits into
petebacondarwin wants to merge 3 commits into
Conversation
petebacondarwin
added
type: bug/fix
action: review
petebacondarwin
force-pushed
the
sourcemaps-patch
branch
from
February 14, 2019 20:34
4779849 to
2f68c7f
Compare
kyliau
approved these changes
Feb 15, 2019
kyliau
left a comment
kyliau
left a comment
Contributor
There was a problem hiding this comment.
LGTM for language service
ocombe
approved these changes
Feb 15, 2019
IgorMinar
approved these changes
Mar 4, 2019
IgorMinar
left a comment
IgorMinar
left a comment
Contributor
There was a problem hiding this comment.
lgtm but needs rebase. thanks
This commit consolidates the options that can modify the parsing of text (e.g. HTML, Angular templates, CSS, i18n) into an AST for further processing into a single `options` hash. This makes the code cleaner and more readable, but also enables us to support further options to parsing without triggering wide ranging changes to code that should not be affected by these new options. Specifically, it will let us pass information about the placement of a template that is being parsed in its containing file, which is essential for accurate SourceMap processing. PR Close angular#28055
…lar#28055) When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571 PR Close angular#28055
…ngular#28055) There were a number of typos and some of the sentences did not read well. PR Close angular#28055
petebacondarwin
force-pushed
the
sourcemaps-patch
branch
from
March 4, 2019 09:54
8097cf5 to
bfffa71
Compare
Contributor
Author
|
Rebased. |
petebacondarwin
added
action: merge
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 4, 2019
This commit consolidates the options that can modify the parsing of text (e.g. HTML, Angular templates, CSS, i18n) into an AST for further processing into a single `options` hash. This makes the code cleaner and more readable, but also enables us to support further options to parsing without triggering wide ranging changes to code that should not be affected by these new options. Specifically, it will let us pass information about the placement of a template that is being parsed in its containing file, which is essential for accurate SourceMap processing. PR Close #28055 PR Close #28736
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 4, 2019
…) (#28736) When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See #24571 PR Close #28055 PR Close #28736
Contributor
|
Merged into 7.2.x branch. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A back port of some of the commits from #28055